[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Weather Forecast QML port
From: "Luis Gabriel Lima" <lampih () gmail ! com>
Date: 2012-08-31 0:47:11
Message-ID: 20120831004711.6945.98444 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 30, 2012, 8:21 a.m., Kai Uwe Broulik wrote:
> > applets/weather/package/metadata.desktop, line 17
> > <http://git.reviewboard.kde.org/r/106225/diff/2/?file=82274#file82274line17>
> >
> > I think it should not be enabled by default but rather
> > X-Plasma-NotificationArea=true
> > so you can put it in systray like you can with the current implementation
>
> Marco Martin wrote:
> enabledbydefault is normal for plasmoids so can stay there
>
> it's true that X-Plasma-NotificationArea=true should be back in
Ok, done.
- Luis Gabriel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106225/#review18267
-----------------------------------------------------------
On Aug. 30, 2012, 1:53 a.m., Luis Gabriel Lima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106225/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2012, 1:53 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> This patch is part of the work done in my GSoC 2012 project.
>
>
> Diffs
> -----
>
> applets/weather/CMakeLists.txt 4ae9c6f
> applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION
> applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION
> applets/weather/package/contents/ui/Notice.qml PRE-CREATION
> applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION
> applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION
> applets/weather/package/contents/ui/Utils.js PRE-CREATION
> applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION
> applets/weather/package/contents/ui/main.qml PRE-CREATION
> applets/weather/package/metadata.desktop PRE-CREATION
> applets/weather/weatherapplet.h a7e7f8d
> applets/weather/weatherapplet.cpp 9fd3e5f
> applets/weather/weatherdelegate.h 8a27f0d
> applets/weather/weatherdelegate.cpp 1cd987b
> applets/weather/weatherview.h f177501
> applets/weather/weatherview.cpp 5234cd3
>
> Diff: http://git.reviewboard.kde.org/r/106225/diff/
>
>
> Testing
> -------
>
> - Tested inside panels and floating on desktop
> - Tested with various providers and locations
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/106225/s/696/
>
> http://git.reviewboard.kde.org/r/106225/s/698/
>
> http://git.reviewboard.kde.org/r/106225/s/699/
>
> http://git.reviewboard.kde.org/r/106225/s/700/
>
>
> Thanks,
>
> Luis Gabriel Lima
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106225/">http://git.reviewboard.kde.org/r/106225/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 30th, 2012, 8:21 a.m., <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106225/diff/2/?file=82274#file82274line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/weather/package/metadata.desktop</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">X-KDE-PluginInfo-EnabledByDefault=true</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it should not be \
enabled by default but rather X-Plasma-NotificationArea=true
so you can put it in systray like you can with the current implementation</pre>
</blockquote>
<p>On August 30th, 2012, 8:38 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">enabledbydefault is \
normal for plasmoids so can stay there
it's true that X-Plasma-NotificationArea=true should be back in</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, \
done.</pre> <br />
<p>- Luis Gabriel</p>
<br />
<p>On August 30th, 2012, 1:53 a.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2012, 1:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is part of the work done in my GSoC 2012 project.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Tested inside panels and floating on desktop
- Tested with various providers and locations</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/weather/CMakeLists.txt <span style="color: grey">(4ae9c6f)</span></li>
<li>applets/weather/package/contents/ui/DetailsView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/FiveDaysView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/Notice.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/NoticesView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/TopPanel.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/Utils.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/WeatherListView.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/weather/weatherapplet.h <span style="color: grey">(a7e7f8d)</span></li>
<li>applets/weather/weatherapplet.cpp <span style="color: \
grey">(9fd3e5f)</span></li>
<li>applets/weather/weatherdelegate.h <span style="color: \
grey">(8a27f0d)</span></li>
<li>applets/weather/weatherdelegate.cpp <span style="color: \
grey">(1cd987b)</span></li>
<li>applets/weather/weatherview.h <span style="color: grey">(f177501)</span></li>
<li>applets/weather/weatherview.cpp <span style="color: grey">(5234cd3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106225/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106225/s/696/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather11_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/106225/s/698/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather12_1_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/106225/s/699/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather21_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
<a href="http://git.reviewboard.kde.org/r/106225/s/700/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/26/weather22_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic