This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/

On August 30th, 2012, 8:21 a.m., Kai Uwe Broulik wrote:

applets/weather/package/metadata.desktop (Diff revision 2) 


  

 




 
 



 

  

    
    

    17
    
X-KDE-PluginInfo-EnabledByDefault=true

  


 




  
I think it should not be enabled by default but rather
X-Plasma-NotificationArea=true
so you can put it in systray like you can with the current implementation

 




 
On August 30th, 2012, 8:38 a.m., Marco Martin wrote:

 

  
enabledbydefault is normal for plasmoids so can stay there

it's true that X-Plasma-NotificationArea=true should be back in

 











Ok, done.








- Luis Gabriel






On August 30th, 2012, 1:53 a.m., Luis Gabriel Lima wrote:









 

  


Review request for Plasma and Marco Martin.


By Luis Gabriel Lima.




Updated Aug. 30, 2012, 1:53 a.m.








Description 

 

 

  
   
This patch is part of the work done in my GSoC 2012 project.

  		
 






Testing 



 

  
   
- Tested inside panels and floating on desktop
- Tested with various providers and locations

  		
 








Diffs 


    

 
  • applets/weather/CMakeLists.txt (4ae9c6f)
    • 

 
  • applets/weather/package/contents/ui/DetailsView.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/FiveDaysView.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/Notice.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/NoticesView.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/TopPanel.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/Utils.js (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/WeatherListView.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/contents/ui/main.qml (PRE-CREATION)
    • 

 
  • applets/weather/package/metadata.desktop (PRE-CREATION)
    • 

 
  • applets/weather/weatherapplet.h (a7e7f8d)
    • 

 
  • applets/weather/weatherapplet.cpp (9fd3e5f)
    • 

 
  • applets/weather/weatherdelegate.h (8a27f0d)
    • 

 
  • applets/weather/weatherdelegate.cpp (1cd987b)
    • 

 
  • applets/weather/weatherview.h (f177501)
    • 

 
  • applets/weather/weatherview.cpp (5234cd3)
    • 





View Diff





Screenshots