[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make it possible to have a QAbstractItemModel as a property
From: "Commit Hook" <null () kde ! org>
Date: 2012-08-29 15:35:18
Message-ID: 20120829153518.3362.59465 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106267/#review18254
-----------------------------------------------------------
This review has been submitted with commit 64b17ff1540ebc89c8117030a4c782e0=
7bbbf322 by Aleix Pol to branch master.
- Commit Hook
On Aug. 29, 2012, 3:25 p.m., Aleix Pol Gonzalez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106267/
> -----------------------------------------------------------
> =
> (Updated Aug. 29, 2012, 3:25 p.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> This patch introduces QAbstractItemModel to QDeclarative when setting up =
the plasma core components.
> =
> This way we don't have to cast to the type ourselves and produce proper Q=
ML errors if the type is not correct.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/core/corebindingsplugin.cpp f08d8b3 =
> plasma/declarativeimports/core/datamodel.h cf82648 =
> plasma/declarativeimports/core/datamodel.cpp 00108b1 =
> =
> Diff: http://git.reviewboard.kde.org/r/106267/diff/
> =
> =
> Testing
> -------
> =
> Plasma::SortFilterModel didn't stop working.
> =
> =
> Thanks,
> =
> Aleix Pol Gonzalez
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106267/">http://git.reviewboard.kde.org/r/106267/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 64b17ff1540ebc89c8117030a4c782e07bbbf322 by Aleix Pol to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 29th, 2012, 3:25 p.m., Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2012, 3:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch introduces QAbstractItemModel to QDeclarative when setting up \
the plasma core components.
This way we don't have to cast to the type ourselves and produce proper QML \
errors if the type is not correct.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plasma::SortFilterModel didn't stop working.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/corebindingsplugin.cpp <span style="color: \
grey">(f08d8b3)</span></li>
<li>plasma/declarativeimports/core/datamodel.h <span style="color: \
grey">(cf82648)</span></li>
<li>plasma/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(00108b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106267/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic