From kde-panel-devel Wed Aug 29 15:35:18 2012 From: "Commit Hook" Date: Wed, 29 Aug 2012 15:35:18 +0000 To: kde-panel-devel Subject: Re: Review Request: Make it possible to have a QAbstractItemModel as a property Message-Id: <20120829153518.3362.59465 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134625453802946 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5186224466750022409==" --===============5186224466750022409== Content-Type: multipart/alternative; boundary="===============8579004368968437902==" --===============8579004368968437902== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106267/#review18254 ----------------------------------------------------------- This review has been submitted with commit 64b17ff1540ebc89c8117030a4c782e0= 7bbbf322 by Aleix Pol to branch master. - Commit Hook On Aug. 29, 2012, 3:25 p.m., Aleix Pol Gonzalez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106267/ > ----------------------------------------------------------- > = > (Updated Aug. 29, 2012, 3:25 p.m.) > = > = > Review request for Plasma and Marco Martin. > = > = > Description > ------- > = > This patch introduces QAbstractItemModel to QDeclarative when setting up = the plasma core components. > = > This way we don't have to cast to the type ourselves and produce proper Q= ML errors if the type is not correct. > = > = > Diffs > ----- > = > plasma/declarativeimports/core/corebindingsplugin.cpp f08d8b3 = > plasma/declarativeimports/core/datamodel.h cf82648 = > plasma/declarativeimports/core/datamodel.cpp 00108b1 = > = > Diff: http://git.reviewboard.kde.org/r/106267/diff/ > = > = > Testing > ------- > = > Plasma::SortFilterModel didn't stop working. > = > = > Thanks, > = > Aleix Pol Gonzalez > = > --===============8579004368968437902== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106267/ 

This revie=
w has been submitted with commit 64b17ff1540ebc89c8117030a4c782e07bbbf322 b=
y Aleix Pol to branch master.

- Commit


On August 29th, 2012, 3:25 p.m., Aleix Pol Gonzalez wrote:

Review request for Plasma and Marco Martin.
By Aleix Pol Gonzalez.

Updated Aug. 29, 2012, 3:25 p.m.

Descripti= on 

This patch introduces QAbstractItemModel to QDeclarative whe=
n setting up the plasma core components.

This way we don't have to cast to the type ourselves and produce proper=
 QML errors if the type is not correct.

Testing <= /h1> 
Plasma::SortFilterModel didn't stop working.

Diffs=

  • plasma/declarativeimports/core/corebindingsplugin.cpp (f08d8b3)
  • plasma/declarativeimports/core/datamodel.h (cf82648)
  • plasma/declarativeimports/core/datamodel.cpp (00108b1)

View Diff
--===============8579004368968437902==-- --===============5186224466750022409== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5186224466750022409==--