[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Dictionary Runner
From: "David Edmundson" <kde () davidedmundson ! co ! uk>
Date: 2012-08-28 14:56:31
Message-ID: 20120828145631.8723.22473 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106068/#review18164
-----------------------------------------------------------
Ship it!
Code was generally really good, minor comments below. One somewhat importan=
t.
runners/dictionary/dictionarymatchengine.h
<http://git.reviewboard.kde.org/r/106068/#comment14389>
*important*
=
This is not a valid license header. Copy and paste the correct one from=
somewhere else.
runners/dictionary/dictionarymatchengine.cpp
<http://git.reviewboard.kde.org/r/106068/#comment14388>
License
runners/dictionary/dictionaryrunner.h
<http://git.reviewboard.kde.org/r/106068/#comment14387>
License...etc for all other files.
runners/dictionary/dictionaryrunner_config.cpp
<http://git.reviewboard.kde.org/r/106068/#comment14386>
Use KLineEdit unless there's a good reason not to.
runners/dictionary/dictionaryrunner_config.cpp
<http://git.reviewboard.kde.org/r/106068/#comment14390>
Would be better to get this i18nc appearing only once. =
=
(a static method somewhere perhaps)
=
currently if a translator translates it differently in one of the 3 pla=
ces, it breaks.
- David Edmundson
On Aug. 18, 2012, 3:57 a.m., Jason A. Donenfeld wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106068/
> -----------------------------------------------------------
> =
> (Updated Aug. 18, 2012, 3:57 a.m.)
> =
> =
> Review request for Plasma, Jason A. Donenfeld and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> Jason's dictionary runner plugin for krunner.
> =
> =
> Diffs
> -----
> =
> runners/CMakeLists.txt f487563c58b5bacc5e49b9e1a0f6e306956bbf7f =
> runners/dictionary/CMakeLists.txt PRE-CREATION =
> runners/dictionary/Messages.sh PRE-CREATION =
> runners/dictionary/dictionarymatchengine.h PRE-CREATION =
> runners/dictionary/dictionarymatchengine.cpp PRE-CREATION =
> runners/dictionary/dictionaryrunner.h PRE-CREATION =
> runners/dictionary/dictionaryrunner.cpp PRE-CREATION =
> runners/dictionary/dictionaryrunner_config.h PRE-CREATION =
> runners/dictionary/dictionaryrunner_config.cpp PRE-CREATION =
> runners/dictionary/plasma-runner-dictionary.desktop PRE-CREATION =
> runners/dictionary/plasma-runner-dictionary_config.desktop PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/106068/diff/
> =
> =
> Testing
> -------
> =
> Works well under various different loads.
> =
> =
> Screenshots
> -----------
> =
> The Runner in Action
> http://git.reviewboard.kde.org/r/106068/s/679/
> =
> =
> Thanks,
> =
> Jason A. Donenfeld
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106068/">http://git.reviewboard.kde.org/r/106068/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code was generally \
really good, minor comments below. One somewhat important.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106068/diff/1/?file=78359#file78359line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/dictionary/dictionarymatchengine.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2010, 2012 Jason A. Donenfeld \
<Jason@zx2c4.com></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*important*
This is not a valid license header. Copy and paste the correct one from somewhere \
else.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106068/diff/1/?file=78360#file78360line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/dictionary/dictionarymatchengine.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2010, 2012 Jason A. Donenfeld \
<Jason@zx2c4.com></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">License</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106068/diff/1/?file=78361#file78361line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/dictionary/dictionaryrunner.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2010, 2012 Jason A. Donenfeld \
<Jason@zx2c4.com></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">License...etc for all other files.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106068/diff/1/?file=78364#file78364line16" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/dictionary/dictionaryrunner_config.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">DictionaryRunnerConfig::DictionaryRunnerConfig(QWidget* parent, const \
QVariantList& args) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">16</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">m_triggerWord</span> <span class="o">=</span> \
<span class="k">new</span> <span class="n">QLineEdit</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use \
KLineEdit unless there's a good reason not to.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106068/diff/1/?file=78364#file78364line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">runners/dictionary/dictionaryrunner_config.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">DictionaryRunnerConfig::DictionaryRunnerConfig(QWidget* parent, const \
QVariantList& args) :</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">m_triggerWord</span><span \
class="o">-></span><span class="n">setText</span><span class="p">(</span><span \
class="n">grp</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="n">CONFIG_TRIGGERWORD</span><span class="p">,</span> \
<span class="n">i18nc</span><span class="p">(</span><span class="s">"Trigger \
word before word to define"</span><span class="p">,</span> <span \
class="s">"define"</span><span class="p">)));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would be \
better to get this i18nc appearing only once.
(a static method somewhere perhaps)
currently if a translator translates it differently in one of the 3 places, it \
breaks.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On August 18th, 2012, 3:57 a.m., Jason A. Donenfeld wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Jason A. Donenfeld and Aaron J. Seigo.</div>
<div>By Jason A. Donenfeld.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 3:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Jason's dictionary runner plugin for krunner.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works well under various different loads.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: \
grey">(f487563c58b5bacc5e49b9e1a0f6e306956bbf7f)</span></li>
<li>runners/dictionary/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionarymatchengine.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionarymatchengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionaryrunner.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionaryrunner.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionaryrunner_config.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/dictionaryrunner_config.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/plasma-runner-dictionary.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>runners/dictionary/plasma-runner-dictionary_config.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106068/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106068/s/679/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/08/18/krunner-modernized-dictionary-runner_400x100.png" \
style="border: 1px black solid;" alt="The Runner in Action" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic