Ship it!
Code was generally really good, minor comments below. One somewhat important.
*important*
This is not a valid license header. Copy and paste the correct one from somewhere else.
License...etc for all other files.
Use KLineEdit unless there's a good reason not to.
|
runners/dictionary/dictionaryrunner_config.cpp
(Diff revision 1)
|
|
DictionaryRunnerConfig::DictionaryRunnerConfig(QWidget* parent, const QVariantList& args) : |
|
|
29 |
m_triggerWord->setText(grp.readEntry(CONFIG_TRIGGERWORD, i18nc("Trigger word before word to define", "define"))); |
Would be better to get this i18nc appearing only once.
(a static method somewhere perhaps)
currently if a translator translates it differently in one of the 3 places, it breaks.
- David
On August 18th, 2012, 3:57 a.m., Jason A. Donenfeld wrote:
|
Review request for Plasma, Jason A. Donenfeld and Aaron J. Seigo.
By Jason A. Donenfeld.
Updated Aug. 18, 2012, 3:57 a.m.
Description
Jason's dictionary runner plugin for krunner.
|
Testing
Works well under various different loads.
|
Diffs
- runners/CMakeLists.txt (f487563c58b5bacc5e49b9e1a0f6e306956bbf7f)
- runners/dictionary/CMakeLists.txt (PRE-CREATION)
- runners/dictionary/Messages.sh (PRE-CREATION)
- runners/dictionary/dictionarymatchengine.h (PRE-CREATION)
- runners/dictionary/dictionarymatchengine.cpp (PRE-CREATION)
- runners/dictionary/dictionaryrunner.h (PRE-CREATION)
- runners/dictionary/dictionaryrunner.cpp (PRE-CREATION)
- runners/dictionary/dictionaryrunner_config.h (PRE-CREATION)
- runners/dictionary/dictionaryrunner_config.cpp (PRE-CREATION)
- runners/dictionary/plasma-runner-dictionary.desktop (PRE-CREATION)
- runners/dictionary/plasma-runner-dictionary_config.desktop (PRE-CREATION)
View Diff
Screenshots
|
