[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add fade effect on the nowplaying text cycling
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2012-08-23 10:51:06
Message-ID: 20120823105106.10572.28875 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote:
> > This review has been submitted with commit 48ccff55dabc7ad9a173ee6b50d9=
55c85e42aa27 by Martin Klapetek to branch KDE/4.9.
> =
> Alex Merry wrote:
> I don't think this should really have gone into 4.9, as it is a featu=
re, rather than a bug fix.
Depends. Would it be a bug if I opened a bug report first (as it was a bug =
from my point of view)? Also I don't think it's a feature really, enhanceme=
nt/improvement yes, but feature? Not really.
For the record - I asked if that can go in 4.9 first.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106095/#review17810
-----------------------------------------------------------
On Aug. 20, 2012, 11:13 a.m., Martin Klapetek wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106095/
> -----------------------------------------------------------
> =
> (Updated Aug. 20, 2012, 11:13 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> When the nowplaying is in panel, it cycles through title, artist and albu=
m in one Label. This adds a simple, decent fade effect between the changes.
> =
> =
> Diffs
> -----
> =
> applets/nowplaying/package/contents/ui/MetadataLine.qml b793464 =
> =
> Diff: http://git.reviewboard.kde.org/r/106095/diff/
> =
> =
> Testing
> -------
> =
> In plasmoidviewer.
> =
> =
> Thanks,
> =
> Martin Klapetek
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106095/">http://git.reviewboard.kde.org/r/106095/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 21st, 2012, 3:54 p.m., <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
48ccff55dabc7ad9a173ee6b50d955c85e42aa27 by Martin Klapetek to branch KDE/4.9.</pre> \
</blockquote>
<p>On August 23rd, 2012, 10:32 a.m., <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this \
should really have gone into 4.9, as it is a feature, rather than a bug fix.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Depends. Would it be a \
bug if I opened a bug report first (as it was a bug from my point of view)? Also I \
don't think it's a feature really, enhancement/improvement yes, but feature? \
Not really.
For the record - I asked if that can go in 4.9 first.</pre>
<br />
<p>- Martin</p>
<br />
<p>On August 20th, 2012, 11:13 a.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 11:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the nowplaying is in panel, it cycles through title, artist and \
album in one Label. This adds a simple, decent fade effect between the changes.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In plasmoidviewer.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/nowplaying/package/contents/ui/MetadataLine.qml <span style="color: \
grey">(b793464)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic