--===============7810988678935525343== Content-Type: multipart/alternative; boundary="===============0959891292830799124==" --===============0959891292830799124== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 21, 2012, 3:54 p.m., Commit Hook wrote: > > This review has been submitted with commit 48ccff55dabc7ad9a173ee6b50d9= 55c85e42aa27 by Martin Klapetek to branch KDE/4.9. > = > Alex Merry wrote: > I don't think this should really have gone into 4.9, as it is a featu= re, rather than a bug fix. Depends. Would it be a bug if I opened a bug report first (as it was a bug = from my point of view)? Also I don't think it's a feature really, enhanceme= nt/improvement yes, but feature? Not really. For the record - I asked if that can go in 4.9 first. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106095/#review17810 ----------------------------------------------------------- On Aug. 20, 2012, 11:13 a.m., Martin Klapetek wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106095/ > ----------------------------------------------------------- > = > (Updated Aug. 20, 2012, 11:13 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > When the nowplaying is in panel, it cycles through title, artist and albu= m in one Label. This adds a simple, decent fade effect between the changes. > = > = > Diffs > ----- > = > applets/nowplaying/package/contents/ui/MetadataLine.qml b793464 = > = > Diff: http://git.reviewboard.kde.org/r/106095/diff/ > = > = > Testing > ------- > = > In plasmoidviewer. > = > = > Thanks, > = > Martin Klapetek > = > --===============0959891292830799124== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106095/

On August 21st, 2012, 3:54 p.m., Commit Hoo= k wrote:

This revi=
ew has been submitted with commit 48ccff55dabc7ad9a173ee6b50d955c85e42aa27 =
by Martin Klapetek to branch KDE/4.9.

On August 23rd, 2012, 10:32 a.m., Alex Merry wrote:

I don'=
;t think this should really have gone into 4.9, as it is a feature, rather =
than a bug fix.
Depends. Wo=
uld it be a bug if I opened a bug report first (as it was a bug from my poi=
nt of view)? Also I don't think it's a feature really, enhancement/=
improvement yes, but feature? Not really.

For the record - I asked if that can go in 4.9 first.

- Martin


On August 20th, 2012, 11:13 a.m., Martin Klapetek wrote:

Review request for Plasma.
By Martin Klapetek.

Updated Aug. 20, 2012, 11:13 a.m.

Descripti= on 

When the nowplaying is in panel, it cycles through title, ar=
tist and album in one Label. This adds a simple, decent fade effect between=
 the changes.

Testing <= /h1> 
In plasmoidviewer.

Diffs=

  • applets/nowplaying/package/contents/ui/MetadataLine.qml (b793464)

View Diff
--===============0959891292830799124==-- --===============7810988678935525343== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7810988678935525343==--