[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adding notify signals to FrameSvgItem
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-08-21 20:08:15
Message-ID: 20120821200815.7963.41330 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 12, 2012, 10:41 a.m., Christoph Feck wrote:
> > As I understand it, the notify system is for attributes, where the obje=
ct changes the value _itself_ (e.g. in response to user interaction), as op=
posed to where the application changed the value.
> > =
> > In that light, an imagePathChanged() would not make sense, because the =
path cannot change, except if the application changes it.
> > =
> > What am I missing?
> =
> Marco Martin wrote:
> the notify signal, should be for all properties that can change run t=
ime, no matter who is changing it (and of course the object itself is able =
to know in any way when the property changes to be able to reliably signal =
it).
> =
> the use case is property binding: if you have many classes that are b=
inded to a property, you want all of them immediately automatically updated=
with the new property value.
> =
> an example that doesn't necessary make sense per se but exemplifies, =
3 instances of Text {text: framesvgItem.imagePath} should always have the"r=
ight" text
Erm, what I actually had been missing is the fact, that this commit is for =
QML bindings, not for the actual FrameSvg class in kdelibs/plasma... Sorry =
for the noise.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105987/#review17265
-----------------------------------------------------------
On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105987/
> -----------------------------------------------------------
> =
> (Updated Aug. 11, 2012, 10:39 p.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> When we are using a QML element, we should be able to keep track of its p=
roperty changes.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/core/framesvgitem.h 7baf0cf =
> plasma/declarativeimports/core/framesvgitem.cpp 02c9d19 =
> =
> Diff: http://git.reviewboard.kde.org/r/105987/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Luis Gabriel Lima
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105987/">http://git.reviewboard.kde.org/r/105987/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 12th, 2012, 10:41 a.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As I understand it, the notify system is for attributes, where the \
object changes the value _itself_ (e.g. in response to user interaction), as opposed \
to where the application changed the value.
In that light, an imagePathChanged() would not make sense, because the path cannot \
change, except if the application changes it.
What am I missing?</pre>
</blockquote>
<p>On August 12th, 2012, 10:58 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the notify signal, \
should be for all properties that can change run time, no matter who is changing it \
(and of course the object itself is able to know in any way when the property changes \
to be able to reliably signal it).
the use case is property binding: if you have many classes that are binded to a \
property, you want all of them immediately automatically updated with the new \
property value.
an example that doesn't necessary make sense per se but exemplifies, 3 instances \
of Text {text: framesvgItem.imagePath} should always have the"right" \
text</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Erm, what I actually had \
been missing is the fact, that this commit is for QML bindings, not for the actual \
FrameSvg class in kdelibs/plasma... Sorry for the noise.</pre> <br />
<p>- Christoph</p>
<br />
<p>On August 11th, 2012, 10:39 p.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When we are using a QML element, we should be able to keep track of its \
property changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/framesvgitem.h <span style="color: \
grey">(7baf0cf)</span></li>
<li>plasma/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(02c9d19)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105987/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic