[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make autohide panel do not intercept events in fullscreen app
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-08-21 19:18:04
Message-ID: 20120821191804.4600.52439 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 21, 2012, 10:24 a.m., Christoph Feck wrote:
> > If this "feature" is going to be implemented, it should be configurable. If you \
> > are only using a mouse (or stylus on a Tablet PC), then you would have no way to \
> > reach the panel in full-screen mode. The better solution would be if plasma \
> > developers would implement the much requested panel delays, and have it increased \
> > when in full-screen mode.
> > In a related note, I also find it odd that the auto-hide panel does not go above \
> > "Keep Above Others" windows, but that may be intended. An auto-hide panel is a \
> > temporary window like a menu, so it should not be covered by anything except \
> > other such menus.
>
> Alexey Shmalko wrote:
> There is no way to interact with panel of any kind in fullscreen apps for now, \
> except switching application in normal mode. But exactly auto-hide panel blocks \
> area, where it should be, and doesn't appear or react on mouse events at all. \
> Events are lost, the panel doesn't appear and the area the panel shoud cover is \
> unresponsive.
Oh, I confused "full-screen" with "fully maximized" again. I just checked, and indeed \
input is blocked by the panel helper window.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review17799
-----------------------------------------------------------
On Aug. 21, 2012, 10:06 a.m., Alexey Shmalko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2012, 10:06 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Make autohide panel do not intercept events in fullscreen app.
>
> I changed PanelView::shouldHintHide() to return true if current active application \
> is in fullscreen mode. So in fullscreen applications panel will be always hidden.
>
> This addresses bugs 297920 and 305497.
> http://bugs.kde.org/show_bug.cgi?id=297920
> http://bugs.kde.org/show_bug.cgi?id=305497
>
>
> Diffs
> -----
>
> plasma/desktop/shell/panelview.cpp 7713740
>
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexey Shmalko
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106110/">http://git.reviewboard.kde.org/r/106110/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 21st, 2012, 10:24 a.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If this "feature" is going to be implemented, it should be \
configurable. If you are only using a mouse (or stylus on a Tablet PC), then you \
would have no way to reach the panel in full-screen mode. The better solution would \
be if plasma developers would implement the much requested panel delays, and have it \
increased when in full-screen mode.
In a related note, I also find it odd that the auto-hide panel does not go above \
"Keep Above Others" windows, but that may be intended. An auto-hide panel \
is a temporary window like a menu, so it should not be covered by anything except \
other such menus.</pre> </blockquote>
<p>On August 21st, 2012, 10:56 a.m., <b>Alexey Shmalko</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no way to \
interact with panel of any kind in fullscreen apps for now, except switching \
application in normal mode. But exactly auto-hide panel blocks area, where it should \
be, and doesn't appear or react on mouse events at all. Events are lost, the \
panel doesn't appear and the area the panel shoud cover is unresponsive.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, I confused \
"full-screen" with "fully maximized" again. I just checked, and \
indeed input is blocked by the panel helper window.</pre> <br />
<p>- Christoph</p>
<br />
<p>On August 21st, 2012, 10:06 a.m., Alexey Shmalko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alexey Shmalko.</div>
<p style="color: grey;"><i>Updated Aug. 21, 2012, 10:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make autohide panel do not intercept events in fullscreen app.
I changed PanelView::shouldHintHide() to return true if current active application is \
in fullscreen mode. So in fullscreen applications panel will be always hidden.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297920">297920</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=305497">305497</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/panelview.cpp <span style="color: \
grey">(7713740)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic