'Re: Review Request: Adding notify signals to FrameSvgItem'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Adding notify signals to FrameSvgItem
From:       "Commit Hook" <null () kde ! org>
Date:       2012-08-12 18:16:22
Message-ID: 20120812181622.24339.94824 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105987/#review17276
-----------------------------------------------------------

This review has been submitted with commit b7f7262faafbfcf7d134d9e8c0dc1ab4=
08e40ac1 by Lu=C3=ADs Gabriel Lima to branch master.

- Commit Hook

On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105987/
> -----------------------------------------------------------
> =

> (Updated Aug. 11, 2012, 10:39 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> When we are using a QML element, we should be able to keep track of its p=
roperty changes.
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/core/framesvgitem.h 7baf0cf =

>   plasma/declarativeimports/core/framesvgitem.cpp 02c9d19 =

> =

> Diff: http://git.reviewboard.kde.org/r/105987/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Luis Gabriel Lima
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105987/">http://git.reviewboard.kde.org/r/105987/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b7f7262faafbfcf7d134d9e8c0dc1ab408e40ac1 by Luís Gabriel Lima \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On August 11th, 2012, 10:39 p.m., Luis Gabriel Lima wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>

<p style="color: grey;"><i>Updated Aug. 11, 2012, 10:39 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When we are using a QML element, we should be able to keep track of its \
property changes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/framesvgitem.h <span style="color: \
grey">(7baf0cf)</span></li>

 <li>plasma/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(02c9d19)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105987/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 