[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adding notify signals to FrameSvgItem
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2012-08-12 13:05:57
Message-ID: 20120812130557.1136.82268 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105987/#review17273
-----------------------------------------------------------
Just 2 minor issues for naming consistency.
plasma/declarativeimports/core/framesvgitem.h
<http://git.reviewboard.kde.org/r/105987/#comment13450>
Please change it to "enabledBordersChanged" to stay consistent with "se=
tEnabledBorders" and "enabledBorders".
plasma/declarativeimports/core/framesvgitem.h
<http://git.reviewboard.kde.org/r/105987/#comment13451>
Please change it to "enabledBordersChanged" to stay consistent with "se=
tEnabledBorders" and "enabledBorders".
- Mark Gaiser
On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105987/
> -----------------------------------------------------------
> =
> (Updated Aug. 11, 2012, 10:39 p.m.)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Description
> -------
> =
> When we are using a QML element, we should be able to keep track of its p=
roperty changes.
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/core/framesvgitem.h 7baf0cf =
> plasma/declarativeimports/core/framesvgitem.cpp 02c9d19 =
> =
> Diff: http://git.reviewboard.kde.org/r/105987/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Luis Gabriel Lima
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105987/">http://git.reviewboard.kde.org/r/105987/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just 2 minor issues for \
naming consistency.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105987/diff/1/?file=77162#file77162line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/core/framesvgitem.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
FrameSvgItem : public QDeclarativeItem</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">Plasma</span><span \
class="o">::</span><span class="n">FrameSvg</span><span class="o">::</span><span \
class="n">EnabledBorders</span> <span class="n">enabledBorders</span> <span \
class="n">READ</span> <span class="n">enabledBorders</span> <span \
class="n">WRITE</span> <span class="n">setEnabledBorders</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">100</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span \
class="p">(</span><span class="n">Plasma</span><span class="o">::</span><span \
class="n">FrameSvg</span><span class="o">::</span><span \
class="n">EnabledBorders</span> <span class="n">enabledBorders</span> <span \
class="n">READ</span> <span class="n">enabledBorders</span> <span \
class="n">WRITE</span> <span class="n">setEnabledBorders</span><span class="hl"> \
</span><span class="n"><span class="hl">NOTIFY</span></span><span class="hl"> \
</span><span class="n"><span class="hl">enableBordersChanged</span></span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
change it to "enabledBordersChanged" to stay consistent with \
"setEnabledBorders" and "enabledBorders".</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105987/diff/1/?file=77162#file77162line125" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/core/framesvgitem.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">signals:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">125</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">enableBordersChanged</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
change it to "enabledBordersChanged" to stay consistent with \
"setEnabledBorders" and "enabledBorders".</pre> </div>
<br />
<p>- Mark</p>
<br />
<p>On August 11th, 2012, 10:39 p.m., Luis Gabriel Lima wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Luis Gabriel Lima.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When we are using a QML element, we should be able to keep track of its \
property changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/framesvgitem.h <span style="color: \
grey">(7baf0cf)</span></li>
<li>plasma/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(02c9d19)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105987/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic