[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix for: When a new job is shown in the notification applet, initially the title
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-03 11:13:38
Message-ID: 20120803111338.12125.1798 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105821/#review16825
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Aug. 3, 2012, 9:36 a.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105821/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 9:36 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> in the notification applet, set the extender item's title also when creating the job widget.
>
>
> This addresses bug 288093.
> http://bugs.kde.org/show_bug.cgi?id=288093
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/ui/jobwidget.cpp 02371c0
>
> Diff: http://git.reviewboard.kde.org/r/105821/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Koller
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105821/">http://git.reviewboard.kde.org/r/105821/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Marco</p>
<br />
<p>On August 3rd, 2012, 9:36 a.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2012, 9:36 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in the notification applet, set the extender item's title also when \
creating the job widget.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288093">288093</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/ui/jobwidget.cpp <span style="color: \
grey">(02371c0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105821/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic