[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: fix html tag handling in notification message
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-03 11:13:30
Message-ID: 20120803111330.12139.41119 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105836/#review16824
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On Aug. 3, 2012, 9:35 a.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105836/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 9:35 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> as described in the bug report, some combinations of html tags or < > brackets do \
> not display correctly. I found some bugs in the message preparation code which this \
> patch fixes.
>
> This addresses bug 302890.
> http://bugs.kde.org/show_bug.cgi?id=302890
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/ui/notificationwidget.cpp 880f1e4
>
> Diff: http://git.reviewboard.kde.org/r/105836/diff/
>
>
> Testing
> -------
>
> notify-send - 'b < a >'
> notify-send - '<a>'
> notify-send - 'a >'
> notify-send - 'a > b'
> notify-send - 'a>b'
> notify-send - '<a>b'
> notify-send - '>a>b'
> notify-send - '> a > b'
> notify-send - '< a < b'
> notify-send - '< a < b'
> notify-send - '> <'
> notify-send - '>'
> notify-send - '< a < b'
> notify-send - '> a > b'
> notify-send - 'a > a > b'
> notify-send - 'a > '
> notify-send - 'a > b'
>
>
> Thanks,
>
> Martin Koller
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105836/">http://git.reviewboard.kde.org/r/105836/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Marco</p>
<br />
<p>On August 3rd, 2012, 9:35 a.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 3, 2012, 9:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">as described in the bug report, some combinations of html tags or < \
> brackets do not display correctly. I found some bugs in the message preparation \
code which this patch fixes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">notify-send - 'b < a >' notify-send - '<a>'
notify-send - 'a >'
notify-send - 'a > b'
notify-send - 'a>b'
notify-send - '<a>b'
notify-send - '>a>b'
notify-send - '> a > b'
notify-send - '&lt; a &lt; b'
notify-send - '< a &lt; b'
notify-send - '&gt; &lt;'
notify-send - '&gt;'
notify-send - '< a < b'
notify-send - '> a > b'
notify-send - 'a > a > b'
notify-send - 'a > '
notify-send - 'a > b'
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302890">302890</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/ui/notificationwidget.cpp <span \
style="color: grey">(880f1e4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105836/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic