[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support
From: "Marco Gulino" <marco.gulino () gmail ! com>
Date: 2012-07-22 23:22:12
Message-ID: 20120722232212.31042.80344 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 22, 2012, 11:17 p.m., Aleix Pol Gonzalez wrote:
> > I don't see the patch...?
it's in a separate branch (the one specified above) , there are too many fi=
les, a patch wouldn't be handy :-) =
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16244
-----------------------------------------------------------
On July 22, 2012, 10:27 p.m., Marco Gulino wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105673/
> -----------------------------------------------------------
> =
> (Updated July 22, 2012, 10:27 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> I've nearly finished my work on the Bookmarks krunner, at least I think i=
t's ready for a review.
> Main focus: add support for chrome (and chromium).
> Side effects: refactoring, a few unit tests, and Favicons for firefox (it=
's very similar for chrome, they're stored as sqlite blob, so adding favico=
n for chrome meant making easy to add them to firefox too).
> I also removed some code seeming dead, or duplicated.
> =
> I'm mostly unhappy with the favicon fetch from firefox and chrome: i had =
to save them to temp file since it's impossible to load QPixmap in krunner =
plugins.
> =
> What's still missing: maybe a little more testing (both unit and manual) =
and cleanup.
> =
> branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runner=
s/bookmarks
> =
> =
> Diffs
> -----
> =
> =
> Diff: http://git.reviewboard.kde.org/r/105673/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Gulino
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105673/">http://git.reviewboard.kde.org/r/105673/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 22nd, 2012, 11:17 p.m., <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't see the patch...?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it's in a separate \
branch (the one specified above) , there are too many files, a patch wouldn't be \
handy :-) </pre> <br />
<p>- Marco</p>
<br />
<p>On July 22nd, 2012, 10:27 p.m., Marco Gulino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Gulino.</div>
<p style="color: grey;"><i>Updated July 22, 2012, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've nearly finished my work on the Bookmarks krunner, at least I \
think it's ready for a review. Main focus: add support for chrome (and chromium).
Side effects: refactoring, a few unit tests, and Favicons for firefox (it's very \
similar for chrome, they're stored as sqlite blob, so adding favicon for chrome \
meant making easy to add them to firefox too). I also removed some code seeming dead, \
or duplicated.
I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to save \
them to temp file since it's impossible to load QPixmap in krunner plugins.
What's still missing: maybe a little more testing (both unit and manual) and \
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/bookmarks
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105673/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic