'Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: KRunner Bookmarks: implement Chrome/Chromium support
From:       "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date:       2012-07-22 23:17:20
Message-ID: 20120722231720.30917.37564 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16244
-----------------------------------------------------------

I don't see the patch...?

- Aleix Pol Gonzalez

On July 22, 2012, 10:27 p.m., Marco Gulino wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105673/
> -----------------------------------------------------------
> =

> (Updated July 22, 2012, 10:27 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> I've nearly finished my work on the Bookmarks krunner, at least I think i=
t's ready for a review.
> Main focus: add support for chrome (and chromium).
> Side effects: refactoring, a few unit tests, and Favicons for firefox (it=
's very similar for chrome, they're stored as sqlite blob, so adding favico=
n for chrome meant making easy to add them to firefox too).
> I also removed some code seeming dead, or duplicated.
> =

> I'm mostly unhappy with the favicon fetch from firefox and chrome: i had =
to save them to temp file since it's impossible to load QPixmap in krunner =
plugins.
> =

> What's still missing: maybe a little more testing (both unit and manual) =
and cleanup.
> =

> branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runner=
s/bookmarks
> =

> =

> Diffs
> -----
> =

> =

> Diff: http://git.reviewboard.kde.org/r/105673/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Marco Gulino
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105673/">http://git.reviewboard.kde.org/r/105673/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t see the \
patch...?</pre>  <br />

<p>- Aleix</p>

<br />
<p>On July 22nd, 2012, 10:27 p.m., Marco Gulino wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Gulino.</div>

<p style="color: grey;"><i>Updated July 22, 2012, 10:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve nearly finished my work on the Bookmarks krunner, at least I \
think it&#39;s ready for a review. Main focus: add support for chrome (and chromium).
Side effects: refactoring, a few unit tests, and Favicons for firefox (it&#39;s very \
similar for chrome, they&#39;re stored as sqlite blob, so adding favicon for chrome \
meant making easy to add them to firefox too). I also removed some code seeming dead, \
or duplicated.

I&#39;m mostly unhappy with the favicon fetch from firefox and chrome: i had to save \
them to temp file since it&#39;s impossible to load QPixmap in krunner plugins.

What&#39;s still missing: maybe a little more testing (both unit and manual) and \
cleanup.

branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/bookmarks
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105673/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 