[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: ksysguard.deskstop shoud not use generic name "System Monitor" for its "Name" ke
From: "Commit Hook" <null () kde ! org>
Date: 2012-06-29 8:31:48
Message-ID: 20120629083148.9154.74710 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105338/#review15251
-----------------------------------------------------------
This review has been submitted with commit 1bfb808d454312e46436adad5bbcd143e68cbeee \
by Jekyll Wu to branch master.
- Commit Hook
On June 24, 2012, 7:39 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105338/
> -----------------------------------------------------------
>
> (Updated June 24, 2012, 7:39 a.m.)
>
>
> Review request for Plasma and John Tapsell.
>
>
> Description
> -------
>
> Currently, ksysguard.desktop contains "Name=System Monitor" and "GenericName=System \
> Monitor".
> FOD specification[1] writes:
>
> Name Specific name of the application, for example "Mozilla".
> GenericName Generic name of the application, for example "Web Browser".
>
> So I think using a generic name like "System Monitor" for "Name" is problematic. \
> The current situation of using the same generic name for both "Name" and \
> "GenericName" is also questionable.
> The patch simply uses "KSysGuard" for the "Name" key .
>
> [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
>
>
> Diffs
> -----
>
> ksysguard/gui/ksysguard.desktop 7e8ff32
>
> Diff: http://git.reviewboard.kde.org/r/105338/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105338/">http://git.reviewboard.kde.org/r/105338/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 1bfb808d454312e46436adad5bbcd143e68cbeee by Jekyll Wu to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On June 24th, 2012, 7:39 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and John Tapsell.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated June 24, 2012, 7:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, ksysguard.desktop contains "Name=System Monitor" \
and "GenericName=System Monitor".
FOD specification[1] writes:
Name Specific name of the application, for example "Mozilla".
GenericName Generic name of the application, for example "Web Browser".
So I think using a generic name like "System Monitor" for "Name" \
is problematic. The current situation of using the same generic name for both \
"Name" and "GenericName" is also questionable.
The patch simply uses "KSysGuard" for the "Name" key .
[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksysguard/gui/ksysguard.desktop <span style="color: grey">(7e8ff32)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105338/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic