--===============6061976803389988141== Content-Type: multipart/alternative; boundary="===============8459041002565482707==" --===============8459041002565482707== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105338/#review15251 ----------------------------------------------------------- This review has been submitted with commit 1bfb808d454312e46436adad5bbcd143= e68cbeee by Jekyll Wu to branch master. - Commit Hook On June 24, 2012, 7:39 a.m., Jekyll Wu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105338/ > ----------------------------------------------------------- > = > (Updated June 24, 2012, 7:39 a.m.) > = > = > Review request for Plasma and John Tapsell. > = > = > Description > ------- > = > Currently, ksysguard.desktop contains "Name=3DSystem Monitor" and "Generi= cName=3DSystem Monitor". = > = > FOD specification[1] writes: > = > Name Specific name of the application, for example "Mozilla". > GenericName Generic name of the application, for example "Web Browser= ". > = > So I think using a generic name like "System Monitor" for "Name" is probl= ematic. The current situation of using the same generic name for both "Name= " and "GenericName" is also questionable. > = > The patch simply uses "KSysGuard" for the "Name" key . = > = > [1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spe= c-latest.html#recognized-keys > = > = > Diffs > ----- > = > ksysguard/gui/ksysguard.desktop 7e8ff32 = > = > Diff: http://git.reviewboard.kde.org/r/105338/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Jekyll Wu > = > --===============8459041002565482707== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105338/ 

This revie=
w has been submitted with commit 1bfb808d454312e46436adad5bbcd143e68cbeee b=
y Jekyll Wu to branch master.

- Commit


On June 24th, 2012, 7:39 a.m., Jekyll Wu wrote:

Review request for Plasma and John Tapsell.
By Jekyll Wu.

Updated June 24, 2012, 7:39 a.m.

Descripti= on 

Currently, ksysguard.desktop contains "Name=3DSystem Mo=
nitor" and "GenericName=3DSystem Monitor". =


FOD specification[1] writes:

    Name        Specific name of the application, for example "Mozilla=
".
    GenericName Generic name of the application, for example "Web Brow=
ser".

So I think using a generic name like "System Monitor" for "N=
ame" is problematic. The current situation of using the same generic n=
ame for both "Name" and "GenericName" is also questiona=
ble.

The patch simply uses "KSysGuard" for the "Name" key . =


[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-=
latest.html#recognized-keys

Diffs=

  • ksysguard/gui/ksysguard.desktop (7e8ff32)<= /span>

View Diff
--===============8459041002565482707==-- --===============6061976803389988141== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6061976803389988141==--