[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently
From: Johannes_Tröscher <fritz_van_tom () hotmail ! com>
Date: 2012-06-28 21:21:32
Message-ID: 20120628212132.13307.72401 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote:
> > Ship It!
> =
> Johannes Tr=C3=B6scher wrote:
> i'm not that experienced with git.. i've pushed it to master, could y=
ou backport it to 4.9? i don't know how to push single commits
> =
> Greg T wrote:
> I suggest you to use 'git cherry-pick' for that task.
thanks, submitted
- Johannes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105375/#review15231
-----------------------------------------------------------
On June 28, 2012, 3:40 p.m., Johannes Tr=C3=B6scher wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105375/
> -----------------------------------------------------------
> =
> (Updated June 28, 2012, 3:40 p.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> this is mostly visible with dark-themes only.
> as of now the text color got only changed when the "hover-element" was fu=
lly visible. this looked a bit weird.
> this patch adds a ColorAnimation with the same duration as the opacity-an=
imation on the "hover-element" as Behavior for the Label.
> now the color changes fluently on hovering the ToolButton
> =
> =
> Diffs
> -----
> =
> plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 =
> =
> Diff: http://git.reviewboard.kde.org/r/105375/diff/
> =
> =
> Testing
> -------
> =
> tested, works
> =
> =
> Thanks,
> =
> Johannes Tr=C3=B6scher
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105375/">http://git.reviewboard.kde.org/r/105375/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 28th, 2012, 4:58 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On June 28th, 2012, 5:50 p.m., <b>Johannes Tröscher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'm not that \
experienced with git.. i've pushed it to master, could you backport it to 4.9? i \
don't know how to push single commits</pre> </blockquote>
<p>On June 28th, 2012, 7:10 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I suggest you to use \
'git cherry-pick' for that task.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks, submitted</pre> \
<br />
<p>- Johannes</p>
<br />
<p>On June 28th, 2012, 3:40 p.m., Johannes Tröscher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Johannes Tröscher.</div>
<p style="color: grey;"><i>Updated June 28, 2012, 3:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is mostly visible with dark-themes only. as of now the text color \
got only changed when the "hover-element" was fully visible. this looked a \
bit weird. this patch adds a ColorAnimation with the same duration as the \
opacity-animation on the "hover-element" as Behavior for the Label. now the \
color changes fluently on hovering the ToolButton</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested, works</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml <span \
style="color: grey">(1655821)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105375/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic