--===============3585847404868258203== Content-Type: multipart/alternative; boundary="===============1310919795438083467==" --===============1310919795438083467== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote: > > Ship It! > = > Johannes Tr=C3=B6scher wrote: > i'm not that experienced with git.. i've pushed it to master, could y= ou backport it to 4.9? i don't know how to push single commits > = > Greg T wrote: > I suggest you to use 'git cherry-pick' for that task. thanks, submitted - Johannes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105375/#review15231 ----------------------------------------------------------- On June 28, 2012, 3:40 p.m., Johannes Tr=C3=B6scher wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105375/ > ----------------------------------------------------------- > = > (Updated June 28, 2012, 3:40 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > this is mostly visible with dark-themes only. > as of now the text color got only changed when the "hover-element" was fu= lly visible. this looked a bit weird. > this patch adds a ColorAnimation with the same duration as the opacity-an= imation on the "hover-element" as Behavior for the Label. > now the color changes fluently on hovering the ToolButton > = > = > Diffs > ----- > = > plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 1655821 = > = > Diff: http://git.reviewboard.kde.org/r/105375/diff/ > = > = > Testing > ------- > = > tested, works > = > = > Thanks, > = > Johannes Tr=C3=B6scher > = > --===============1310919795438083467== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105375/

On June 28th, 2012, 4:58 p.m., Aaron J. Sei= go wrote:

Ship It!<=
/pre>
 

On June 28th, 2012, 5:50 p.m., Johannes Tr=C3=B6scher wrote:

i'm n=
ot that experienced with git.. i've pushed it to master, could you back=
port it to 4.9? i don't know how to push single commits

On June 28th, 2012, 7:10 p.m., Greg T wrote:

I suggest=
 you to use 'git cherry-pick' for that task.
thanks, sub=
mitted

- Johannes


On June 28th, 2012, 3:40 p.m., Johannes Tr=C3=B6scher wrote:

Review request for Plasma and Aaron J. Seigo.
By Johannes Tr=C3=B6scher.

Updated June 28, 2012, 3:40 p.m.

Descripti= on

this is mostly visible with dark-themes only.
as of now the text color got only changed when the "hover-element"=
; was fully visible. this looked a bit weird.
this patch adds a ColorAnimation with the same duration as the opacity-anim=
ation on the "hover-element" as Behavior for the Label.
now the color changes fluently on hovering the ToolButton

Testing <= /h1>
tested, works

Diffs=

  • plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml (1655821)

View Diff

--===============1310919795438083467==-- --===============3585847404868258203== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3585847404868258203==--