[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2012-06-26 15:08:24
Message-ID: 20120626150824.11318.40726 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 23, 2012, 12:56 p.m., Mark Gaiser wrote:
> > Just wondering. Do you have blur disabled? Otherwise the widget explore=
r misses that.
> =
> Aur=C3=A9lien G=C3=A2teau wrote:
> Yes, for some reason blur does not work here. I don't think it is a p=
roblem of the widget explorer.
> =
> Mark Gaiser wrote:
> Just did a little bit of code diving. It's not blurred because it's u=
sing a QGraphicsWidget. That's not a QWidget based item thus no top level o=
ne and that is why it's not blurred. The same is true for plasmoids btw. Th=
ey are just visible inside a scene and till this moment there isn't a good =
way (with good performance) to blur the background. That will change with Q=
ML 2 and the shaders :) Another reason why i can't wait for Qt 5. So for no=
w it looks like we just have to live with it.
> =
> Aur=C3=A9lien G=C3=A2teau wrote:
> Blur is back again, so I don't think it is related.
ehh, now i'm puzzled :s
But it looks good!
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105329/#review15040
-----------------------------------------------------------
On June 25, 2012, 12:15 p.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105329/
> -----------------------------------------------------------
> =
> (Updated June 25, 2012, 12:15 p.m.)
> =
> =
> Review request for Plasma, KDE Usability and Marco Martin.
> =
> =
> Description
> -------
> =
> I made a few changes to make widget explorer nicer in vertical mode
> =
> - Fix cropped list items.
> - Make buttons use full width.
> - Move "Get new widgets" and action buttons to the bottom so that:
> - different label alignments do not look odd (category button vs others)
> - category button is closer to the list it controls
> =
> Additionally it would be much better if tooltips could appear on the righ=
t (or left) of the current list item instead of on top of it because it eas=
ily gets in the way, but I don't know how to do this. Any idea? An alternat=
ive would be to just drop the tooltip, it currently does more harm than goo=
d imo.
> =
> There is also something weird going on with the backgrounds: the "after" =
screenshots use a opaque background, but that is not part of the patch and =
I don't understand what makes the code pick the opaque or transparent backg=
round. It should be fixed to use the opaque background, again, any idea whe=
re that bug could be?
> =
> =
> Diffs
> -----
> =
> libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDeleg=
ate.qml 68fad80 =
> libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml 4b=
eecec =
> plasma/desktop/shell/activitymanager/package/contents/ui/main.qml 18865=
29 =
> =
> Diff: http://git.reviewboard.kde.org/r/105329/diff/
> =
> =
> Testing
> -------
> =
> - Looks better in vertical mode.
> - No regression in horizontal mode.
> =
> =
> Screenshots
> -----------
> =
> before-after
> http://git.reviewboard.kde.org/r/105329/s/611/
> =
> =
> Thanks,
> =
> Aur=C3=A9lien G=C3=A2teau
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105329/">http://git.reviewboard.kde.org/r/105329/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 23rd, 2012, 12:56 p.m., <b>Mark Gaiser</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just \
wondering. Do you have blur disabled? Otherwise the widget explorer misses \
that.</pre> </blockquote>
<p>On June 24th, 2012, 9:25 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, for some reason \
blur does not work here. I don't think it is a problem of the widget \
explorer.</pre> </blockquote>
<p>On June 25th, 2012, 11:57 p.m., <b>Mark Gaiser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just did a little bit of \
code diving. It's not blurred because it's using a QGraphicsWidget. \
That's not a QWidget based item thus no top level one and that is why it's \
not blurred. The same is true for plasmoids btw. They are just visible inside a scene \
and till this moment there isn't a good way (with good performance) to blur the \
background. That will change with QML 2 and the shaders :) Another reason why i \
can't wait for Qt 5. So for now it looks like we just have to live with it.</pre> \
</blockquote>
<p>On June 26th, 2012, 2:13 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Blur is back again, so I \
don't think it is related.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ehh, now i'm puzzled \
:s But it looks good!</pre>
<br />
<p>- Mark</p>
<br />
<p>On June 25th, 2012, 12:15 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Marco Martin.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 25, 2012, 12:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I made a few changes to make widget explorer nicer in vertical mode
- Fix cropped list items.
- Make buttons use full width.
- Move "Get new widgets" and action buttons to the bottom so that:
- different label alignments do not look odd (category button vs others)
- category button is closer to the list it controls
Additionally it would be much better if tooltips could appear on the right (or left) \
of the current list item instead of on top of it because it easily gets in the way, \
but I don't know how to do this. Any idea? An alternative would be to just drop \
the tooltip, it currently does more harm than good imo.
There is also something weird going on with the backgrounds: the "after" \
screenshots use a opaque background, but that is not part of the patch and I \
don't understand what makes the code pick the opaque or transparent background. \
It should be fixed to use the opaque background, again, any idea where that bug could \
be?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Looks better in vertical mode.
- No regression in horizontal mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDelegate.qml \
<span style="color: grey">(68fad80)</span></li>
<li>libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml <span \
style="color: grey">(4beecec)</span></li>
<li>plasma/desktop/shell/activitymanager/package/contents/ui/main.qml <span \
style="color: grey">(1886529)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105329/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105329/s/611/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/06/25/out_1_400x100.png" \
style="border: 1px black solid;" alt="before-after" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic