--===============0180825694374635229== Content-Type: multipart/alternative; boundary="===============6855602521173409219==" --===============6855602521173409219== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On June 23, 2012, 12:56 p.m., Mark Gaiser wrote: > > Just wondering. Do you have blur disabled? Otherwise the widget explore= r misses that. > = > Aur=C3=A9lien G=C3=A2teau wrote: > Yes, for some reason blur does not work here. I don't think it is a p= roblem of the widget explorer. > = > Mark Gaiser wrote: > Just did a little bit of code diving. It's not blurred because it's u= sing a QGraphicsWidget. That's not a QWidget based item thus no top level o= ne and that is why it's not blurred. The same is true for plasmoids btw. Th= ey are just visible inside a scene and till this moment there isn't a good = way (with good performance) to blur the background. That will change with Q= ML 2 and the shaders :) Another reason why i can't wait for Qt 5. So for no= w it looks like we just have to live with it. > = > Aur=C3=A9lien G=C3=A2teau wrote: > Blur is back again, so I don't think it is related. ehh, now i'm puzzled :s But it looks good! - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15040 ----------------------------------------------------------- On June 25, 2012, 12:15 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105329/ > ----------------------------------------------------------- > = > (Updated June 25, 2012, 12:15 p.m.) > = > = > Review request for Plasma, KDE Usability and Marco Martin. > = > = > Description > ------- > = > I made a few changes to make widget explorer nicer in vertical mode > = > - Fix cropped list items. > - Make buttons use full width. > - Move "Get new widgets" and action buttons to the bottom so that: > - different label alignments do not look odd (category button vs others) > - category button is closer to the list it controls > = > Additionally it would be much better if tooltips could appear on the righ= t (or left) of the current list item instead of on top of it because it eas= ily gets in the way, but I don't know how to do this. Any idea? An alternat= ive would be to just drop the tooltip, it currently does more harm than goo= d imo. > = > There is also something weird going on with the backgrounds: the "after" = screenshots use a opaque background, but that is not part of the patch and = I don't understand what makes the code pick the opaque or transparent backg= round. It should be fixed to use the opaque background, again, any idea whe= re that bug could be? > = > = > Diffs > ----- > = > libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDeleg= ate.qml 68fad80 = > libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml 4b= eecec = > plasma/desktop/shell/activitymanager/package/contents/ui/main.qml 18865= 29 = > = > Diff: http://git.reviewboard.kde.org/r/105329/diff/ > = > = > Testing > ------- > = > - Looks better in vertical mode. > - No regression in horizontal mode. > = > = > Screenshots > ----------- > = > before-after > http://git.reviewboard.kde.org/r/105329/s/611/ > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============6855602521173409219== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105329/

On June 23rd, 2012, 12:56 p.m., Mark Gaiser= wrote:

Just wond=
ering. Do you have blur disabled? Otherwise the widget explorer misses that=
.

On June 24th, 2012, 9:25 p.m., Aur=C3=A9lien G=C3=A2teau wrote:<= /p> 

Yes, for =
some reason blur does not work here. I don't think it is a problem of t=
he widget explorer.

On June 25th, 2012, 11:57 p.m., Mark Gaiser wrote:

Just did =
a little bit of code diving. It's not blurred because it's using a =
QGraphicsWidget. That's not a QWidget based item thus no top level one =
and that is why it's not blurred. The same is true for plasmoids btw. T=
hey are just visible inside a scene and till this moment there isn't a =
good way (with good performance) to blur the background. That will change w=
ith QML 2 and the shaders :) Another reason why i can't wait for Qt 5. =
So for now it looks like we just have to live with it.

On June 26th, 2012, 2:13 p.m., Aur=C3=A9lien G=C3=A2teau wrote:<= /p> 

Blur is b=
ack again, so I don't think it is related.
ehh, now i&=
#39;m puzzled :s
But it looks good!

- Mark


On June 25th, 2012, 12:15 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for Plasma, KDE Usability and Marco Martin.
By Aur=C3=A9lien G=C3=A2teau.

Updated June 25, 2012, 12:15 p.m.

Descripti= on 

I made a few changes to make widget explorer nicer in vertic=
al mode

- Fix cropped list items.
- Make buttons use full width.
- Move "Get new widgets" and action buttons to the bottom so that:
  - different label alignments do not look odd (category button vs others)
  - category button is closer to the list it controls

Additionally it would be much better if tooltips could appear on the right =
(or left) of the current list item instead of on top of it because it easil=
y gets in the way, but I don't know how to do this. Any idea? An altern=
ative would be to just drop the tooltip, it currently does more harm than g=
ood imo.

There is also something weird going on with the backgrounds: the "afte=
r" screenshots use a opaque background, but that is not part of the pa=
tch and I don't understand what makes the code pick the opaque or trans=
parent background. It should be fixed to use the opaque background, again, =
any idea where that bug could be?

Testing <= /h1> 
- Looks better in vertical mode.
- No regression in horizontal mode.

Diffs=

  • libs/plasmagenericshell/widgetsexplorer/package/contents/ui/AppletDele= gate.qml (68fad80)
  • libs/plasmagenericshell/widgetsexplorer/package/contents/ui/main.qml <= span style=3D"color: grey">(4beecec)
  • plasma/desktop/shell/activitymanager/package/contents/ui/main.qml (1886529)

View Diff

Screensho= ts

3D"before-after"
--===============6855602521173409219==-- --===============0180825694374635229== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0180825694374635229==--