[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Support for multiple batteries in battery monitor applet
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-06-20 0:00:13
Message-ID: 20120620000013.24468.41619 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 16, 2012, 6:40 p.m., Marco Martin wrote:
> > i think the change is on the right path, but should wait for the unfreeze, since \
> > is not a "trivial" fix
>
> David Edmundson wrote:
> Given this patch is untested (due to Viranch having only one battery) and that we \
> will have a lot of angry users complaining that the feature is missing, can I \
> suggest we submit a version with this patch to kde-look.org, so that it is \
> available in "get new stuff".
> This will give us the extra testing before we merge in 4.10, and at least provide a \
> workaround we can share for those users, and the people giving support.
> Marco Martin wrote:
> actually a good idea, would give a fixed place to sent people.
>
> Marco Martin wrote:
> uh, this screams syncrotron as well :p
We need to get it tested first. Does anybody have a machine with two batteries? I \
don't, Viranch doesn't, ... The really cool thing is that we can just send a \
.plasmoid file with the improvements to anyone who runs at least beta1, that should \
make it possible to find someone who can give feedback.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105277/#review14800
-----------------------------------------------------------
On June 16, 2012, 3:25 p.m., Viranch Mehta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105277/
> -----------------------------------------------------------
>
> (Updated June 16, 2012, 3:25 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch implements support for computers with multiple batteries in the battery \
> monitor applet.
> I'm not sure if I should push it now or after the unfreeze. This review addresses \
> the bug #301533
>
> This addresses bug 301533.
> http://bugs.kde.org/show_bug.cgi?id=301533
>
>
> Diffs
> -----
>
> plasma/generic/applets/batterymonitor/contents/code/logic.js PRE-CREATION
> plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml a2ab72a
> plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 08a46ec
>
> Diff: http://git.reviewboard.kde.org/r/105277/diff/
>
>
> Testing
> -------
>
> Added dummy battery sources in power management engine and tested with it. Works \
> fine, as expected with such sources.
> Can someone with multiple batteries please test the patch? since I don't have a \
> computer with multiple batteries.
>
> Thanks,
>
> Viranch Mehta
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105277/">http://git.reviewboard.kde.org/r/105277/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 16th, 2012, 6:40 p.m., <b>Marco Martin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think the \
change is on the right path, but should wait for the unfreeze, since is not a \
"trivial" fix</pre> </blockquote>
<p>On June 17th, 2012, 9:15 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given this patch is \
untested (due to Viranch having only one battery) and that we will have a lot of \
angry users complaining that the feature is missing, can I suggest we submit a \
version with this patch to kde-look.org, so that it is available in "get new \
stuff".
This will give us the extra testing before we merge in 4.10, and at least provide a \
workaround we can share for those users, and the people giving support.</pre> \
</blockquote>
<p>On June 17th, 2012, 8:20 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">actually a good idea, \
would give a fixed place to sent people.</pre> </blockquote>
<p>On June 17th, 2012, 8:20 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uh, this screams \
syncrotron as well :p</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We need to get it tested \
first. Does anybody have a machine with two batteries? I don't, Viranch \
doesn't, ... The really cool thing is that we can just send a .plasmoid file with \
the improvements to anyone who runs at least beta1, that should make it possible to \
find someone who can give feedback.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On June 16th, 2012, 3:25 p.m., Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated June 16, 2012, 3:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements support for computers with multiple batteries in \
the battery monitor applet.
I'm not sure if I should push it now or after the unfreeze. This review addresses \
the bug #301533</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added dummy battery sources in power management engine and tested with \
it. Works fine, as expected with such sources.
Can someone with multiple batteries please test the patch? since I don't have a \
computer with multiple batteries.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301533">301533</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/batterymonitor/contents/code/logic.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span \
style="color: grey">(a2ab72a)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(08a46ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105277/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic