[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Icon applet - Recognition of desktop files without .desktop extension
From: "Commit Hook" <null () kde ! org>
Date: 2012-06-19 18:57:01
Message-ID: 20120619185701.30081.43278 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104764/#review14893
-----------------------------------------------------------
This review has been submitted with commit 88627b1f9eaa778b80aaf6cd6bd5f4026b5fade0 \
by Gregor Tätzner to branch master.
- Commit Hook
On April 27, 2012, 6:14 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104764/
> -----------------------------------------------------------
>
> (Updated April 27, 2012, 6:14 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> isDesktopFile() of KDesktopFile only looks at the file extension. This is not \
> sufficient in a lot of cases, i.e. if you create a 'Link to Location' with dolphin \
> it creates a desktop file without the .desktop extension. isDesktopFile check of \
> KFileItem seems to working better and doesn't just look at the file suffix.
>
> This addresses bug 266870.
> http://bugs.kde.org/show_bug.cgi?id=266870
>
>
> Diffs
> -----
>
> plasma/generic/applets/icon/icon.cpp 4bdbae4
>
> Diff: http://git.reviewboard.kde.org/r/104764/diff/
>
>
> Testing
> -------
>
> bug fixed
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104764/">http://git.reviewboard.kde.org/r/104764/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 88627b1f9eaa778b80aaf6cd6bd5f4026b5fade0 by Gregor Tätzner to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 27th, 2012, 6:14 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated April 27, 2012, 6:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">isDesktopFile() of KDesktopFile only looks at the file extension. This \
is not sufficient in a lot of cases, i.e. if you create a 'Link to Location' \
with dolphin it creates a desktop file without the .desktop extension. isDesktopFile \
check of KFileItem seems to working better and doesn't just look at the file \
suffix.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bug fixed</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=266870">266870</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/icon/icon.cpp <span style="color: \
grey">(4bdbae4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104764/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic