'Re: Review Request: Use Config to Provide Activity Icons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Use Config to Provide Activity Icons
From:       "Commit Hook" <null () kde ! org>
Date:       2012-05-26 11:29:05
Message-ID: 20120526112905.9696.78698 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105008/#review14173
-----------------------------------------------------------

This review has been submitted with commit 2e417e38e3b9051eebc24138612ac5731e7a20ad \
by David E. Narváez to branch KDE/4.8.

- Commit Hook

On May 22, 2012, 3:12 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105008/
> -----------------------------------------------------------
> 
> (Updated May 22, 2012, 3:12 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Description
> -------
> 
> Since we can't trust Nepomuk anymore now that ontologies are loaded asynchronously, \
> we better implement the approach we have in master. 
> 
> This addresses bug 298684.
> http://bugs.kde.org/show_bug.cgi?id=298684
> 
> 
> Diffs
> -----
> 
> service/ActivityManager.cpp 8927c43 
> service/ActivityManager_p.h 3ea1d8a 
> 
> Diff: http://git.reviewboard.kde.org/r/105008/diff/
> 
> 
> Testing
> -------
> 
> Log out and back in. Before this patch, icons would probably load later, or not \
> load at all. Now icons are displayed right away when desktop is loaded. 
> 
> Thanks,
> 
> David Narváez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105008/">http://git.reviewboard.kde.org/r/105008/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2e417e38e3b9051eebc24138612ac5731e7a20ad by David E. Narváez \
to branch KDE/4.8.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 22nd, 2012, 3:12 a.m., David Narváez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Ivan Čukić.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated May 22, 2012, 3:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since we can&#39;t trust Nepomuk anymore now that ontologies are loaded \
asynchronously, we better implement the approach we have in master.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Log out and back in. Before this patch, icons would probably load later, \
or not load at all. Now icons are displayed right away when desktop is loaded.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=298684">298684</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>service/ActivityManager.cpp <span style="color: grey">(8927c43)</span></li>

 <li>service/ActivityManager_p.h <span style="color: grey">(3ea1d8a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105008/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 