From kde-panel-devel Sat May 26 11:29:05 2012 From: "Commit Hook" Date: Sat, 26 May 2012 11:29:05 +0000 To: kde-panel-devel Subject: Re: Review Request: Use Config to Provide Activity Icons Message-Id: <20120526112905.9696.78698 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133803193524716 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7186127927667293064==" --===============7186127927667293064== Content-Type: multipart/alternative; boundary="===============3112969884394451251==" --===============3112969884394451251== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105008/#review14173 ----------------------------------------------------------- This review has been submitted with commit 2e417e38e3b9051eebc24138612ac573= 1e7a20ad by David E. Narv=C3=A1ez to branch KDE/4.8. - Commit Hook On May 22, 2012, 3:12 a.m., David Narv=C3=A1ez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105008/ > ----------------------------------------------------------- > = > (Updated May 22, 2012, 3:12 a.m.) > = > = > Review request for Plasma and Ivan =C4=8Cuki=C4=87. > = > = > Description > ------- > = > Since we can't trust Nepomuk anymore now that ontologies are loaded async= hronously, we better implement the approach we have in master. > = > = > This addresses bug 298684. > http://bugs.kde.org/show_bug.cgi?id=3D298684 > = > = > Diffs > ----- > = > service/ActivityManager.cpp 8927c43 = > service/ActivityManager_p.h 3ea1d8a = > = > Diff: http://git.reviewboard.kde.org/r/105008/diff/ > = > = > Testing > ------- > = > Log out and back in. Before this patch, icons would probably load later, = or not load at all. Now icons are displayed right away when desktop is load= ed. > = > = > Thanks, > = > David Narv=C3=A1ez > = > --===============3112969884394451251== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105008/ 

This revie=
w has been submitted with commit 2e417e38e3b9051eebc24138612ac5731e7a20ad b=
y David E. Narv=C3=A1ez to branch KDE/4.8.

- Commit


On May 22nd, 2012, 3:12 a.m., David Narv=C3=A1ez wrote:

Review request for Plasma and Ivan =C4=8Cuki=C4=87.
By David Narv=C3=A1ez.

Updated May 22, 2012, 3:12 a.m.

Descripti= on 

Since we can't trust Nepomuk anymore now that ontologies=
 are loaded asynchronously, we better implement the approach we have in mas=
ter.

Testing <= /h1> 
Log out and back in. Before this patch, icons would probably=
 load later, or not load at all. Now icons are displayed right away when de=
sktop is loaded.
Bugs: 298684

Diffs=

  • service/ActivityManager.cpp (8927c43)
  • service/ActivityManager_p.h (3ea1d8a)

View Diff
--===============3112969884394451251==-- --===============7186127927667293064== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7186127927667293064==--