'Re: Review Request: Avoid multiple map - engine connections'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Avoid multiple map - engine connections
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-05-21 14:37:13
Message-ID: 20120521143713.10545.52102 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105003/#review14021
-----------------------------------------------------------

Ship it!

code wise looks good, the code also looked it was causing multiple connecti=
ons indeed

- Marco Martin

On May 21, 2012, 1:51 p.m., Jacopo De Simoi wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105003/
> -----------------------------------------------------------
> =

> (Updated May 21, 2012, 1:51 p.m.)
> =

> =

> Review request for Plasma and Aaron J. Seigo.
> =

> =

> Description
> -------
> =

> This fixes some multiple connection issues; up to now we connect the map =
to the engine once for each device that is added, hence when some device ch=
anges its state, it triggers the corresponding signal in the map, which in =
turn triggers multiple times  the corresponding slot in the engine.
>  =

> This seems to have been like that from ages. Was there a reason for that?
> =

> =

> Diffs
> -----
> =

>   plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp 4549c=
d4 =

> =

> Diff: http://git.reviewboard.kde.org/r/105003/diff/
> =

> =

> Testing
> -------
> =

> basic testing: everything works as expected.
> =

> =

> Thanks,
> =

> Jacopo De Simoi
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105003/">http://git.reviewboard.kde.org/r/105003/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">code wise looks good, \
the code also looked it was causing multiple connections indeed</pre>  <br />

<p>- Marco</p>

<br />
<p>On May 21st, 2012, 1:51 p.m., Jacopo De Simoi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Jacopo De Simoi.</div>

<p style="color: grey;"><i>Updated May 21, 2012, 1:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes some multiple connection issues; up to now we connect the map \
to the engine once for each device that is added, hence when some device changes its \
state, it triggers the corresponding signal in the map, which in turn triggers \
multiple times  the corresponding slot in the engine.  
This seems to have been like that from ages. Was there a reason for that?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">basic testing: everything works as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp <span \
style="color: grey">(4549cd4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105003/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 