From kde-panel-devel Mon May 21 14:37:13 2012 From: "Marco Martin" Date: Mon, 21 May 2012 14:37:13 +0000 To: kde-panel-devel Subject: Re: Review Request: Avoid multiple map - engine connections Message-Id: <20120521143713.10545.52102 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133761121522386 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8578211392359029241==" --===============8578211392359029241== Content-Type: multipart/alternative; boundary="===============2097699134182081408==" --===============2097699134182081408== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105003/#review14021 ----------------------------------------------------------- Ship it! code wise looks good, the code also looked it was causing multiple connecti= ons indeed - Marco Martin On May 21, 2012, 1:51 p.m., Jacopo De Simoi wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105003/ > ----------------------------------------------------------- > = > (Updated May 21, 2012, 1:51 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > This fixes some multiple connection issues; up to now we connect the map = to the engine once for each device that is added, hence when some device ch= anges its state, it triggers the corresponding signal in the map, which in = turn triggers multiple times the corresponding slot in the engine. > = > This seems to have been like that from ages. Was there a reason for that? > = > = > Diffs > ----- > = > plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp 4549c= d4 = > = > Diff: http://git.reviewboard.kde.org/r/105003/diff/ > = > = > Testing > ------- > = > basic testing: everything works as expected. > = > = > Thanks, > = > Jacopo De Simoi > = > --===============2097699134182081408== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105003/

Ship it!

code wise =
looks good, the code also looked it was causing multiple connections indeed=

- Marco

On May 21st, 2012, 1:51 p.m., Jacopo De Simoi wrote:

Review request for Plasma and Aaron J. Seigo.

By Jacopo De Simoi.

Updated May 21, 2012, 1:51 p.m.

Descripti= on

This fixes some multiple connection issues; up to now we con=
nect the map to the engine once for each device that is added, hence when s=
ome device changes its state, it triggers the corresponding signal in the m=
ap, which in turn triggers multiple times  the corresponding slot in the en=
gine.
 =

This seems to have been like that from ages. Was there a reason for that?

Testing <= /h1>

basic testing: everything works as expected.

Diffs=

plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp (4549cd4)

View Diff

--===============2097699134182081408==-- --===============8578211392359029241== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8578211392359029241==--