'Re: Review Request: Backport 'Fixed Lancelot build when pimlibs are not present''

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Backport 'Fixed Lancelot build when pimlibs are not present'
From:       "Michael Palimaka" <kde () scribeofthenile ! com>
Date:       2012-05-15 20:29:51
Message-ID: 20120515202951.31733.14573 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104875/#review13862
-----------------------------------------------------------

Any objections here?

- Michael Palimaka

On May 6, 2012, 7:27 p.m., Michael Palimaka wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104875/
> -----------------------------------------------------------
> =

> (Updated May 6, 2012, 7:27 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> This patch is currently in master and works great, but the problem is sti=
ll present in KDE/4.8. Any objection to backporting it?
> =

> =

> Diffs
> -----
> =

>   libs/lancelot-datamodels/MessagesKmail.cpp 7c663704dfa2079a99f589357845=
59de73abb03a =

> =

> Diff: http://git.reviewboard.kde.org/r/104875/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Michael Palimaka
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104875/">http://git.reviewboard.kde.org/r/104875/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any objections \
here?</pre>  <br />

<p>- Michael</p>

<br />
<p>On May 6th, 2012, 7:27 p.m., Michael Palimaka wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Michael Palimaka.</div>

<p style="color: grey;"><i>Updated May 6, 2012, 7:27 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is currently in master and works great, but the problem is \
still present in KDE/4.8. Any objection to backporting it?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/lancelot-datamodels/MessagesKmail.cpp <span style="color: \
grey">(7c663704dfa2079a99f58935784559de73abb03a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104875/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 