'Review Request: qml port of showActivityManager (it's just an icon)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: qml port of showActivityManager (it's just an icon)
From:       "Greg T" <yellowcake- () gmx ! net>
Date:       2012-05-15 19:02:12
Message-ID: 20120515190212.20723.65176 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104959/
-----------------------------------------------------------

Review request for Plasma.

Description
-------

Hello, I've played around a bit with the new qml stuff. Basically this port=
 works the same way as the c++ version. Though the icon doesn't glow on mou=
se hover. How can I fix that?

Diffs
-----

  plasma/desktop/applets/CMakeLists.txt 731c70c =

  plasma/desktop/applets/showActivityManagerQml/CMakeLists.txt PRE-CREATION =

  plasma/desktop/applets/showActivityManagerQml/activities.svgz PRE-CREATIO=
N =

  plasma/desktop/applets/showActivityManagerQml/package/contents/ui/main.qm=
l PRE-CREATION =

  plasma/desktop/applets/showActivityManagerQml/package/metadata.desktop PR=
E-CREATION =

  plasma/generic/dataengines/activities/activities.operations f9ce034 =

  plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 =

Diff: http://git.reviewboard.kde.org/r/104959/diff/

Testing
-------

click: activity manager comes up
click again: manager vanishes!

Thanks,

Greg T

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104959/">http://git.reviewboard.kde.org/r/104959/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello, I&#39;ve played around a bit with the new qml stuff. Basically \
this port works the same way as the c++ version. Though the icon doesn&#39;t glow on \
mouse hover. How can I fix that?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">click: activity manager comes up click again: manager vanishes!</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/CMakeLists.txt <span style="color: \
grey">(731c70c)</span></li>

 <li>plasma/desktop/applets/showActivityManagerQml/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/showActivityManagerQml/activities.svgz <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/showActivityManagerQml/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/desktop/applets/showActivityManagerQml/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/activities/activities.operations <span style="color: \
grey">(f9ce034)</span></li>

 <li>plasma/generic/dataengines/activities/activityjob.cpp <span style="color: \
grey">(7fe8823)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104959/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 