'Re: Review Request: Allow QML items to be associated with operations in Plasma::Service'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Allow QML items to be associated with operations in Plasma::Service
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2012-04-27 20:47:49
Message-ID: 20120427204749.15117.42214 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104760/
-----------------------------------------------------------

(Updated April 27, 2012, 8:47 p.m.)

Review request for Plasma.

Changes
-------

Rename the new methods to associateItem/disassociateItem, since otherwise t=
he scriptengine can't disambiguate when passed a QGraphicsWidget.

Description (updated)
-------

Allow QML items to be associated with operations in Plasma::Service

QML items derive from QGraphicsObject, but not QGraphicsWidget.  We
actually only need QGraphicsObject (for the enabled property).

This allows QML items to be associated with operations (eg: in declarative =
applets).

The new methods are called (dis)associateItem to prevent disambiguation iss=
ues.

Diffs (updated)
-----

  plasma/private/service_p.h 8afef0b6f1ca8bfa11b271fd3b29bc033a94c9a5 =

  plasma/service.h 314909ba84702beb16a36208d1a3c058b1a20f77 =

  plasma/service.cpp 3846e817d013cf26e2dcf57c5fd86783f061bb13 =

Diff: http://git.reviewboard.kde.org/r/104760/diff/

Testing
-------

Tested with a QML plasmoid in plasmoidviewer.

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104760/">http://git.reviewboard.kde.org/r/104760/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated April 27, 2012, 8:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rename the new methods to associateItem/disassociateItem, since \
otherwise the scriptengine can&#39;t disambiguate when passed a \
QGraphicsWidget.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow QML items to be associated with operations in Plasma::Service

QML items derive from QGraphicsObject, but not QGraphicsWidget.  We
actually only need QGraphicsObject (for the enabled property).

This allows QML items to be associated with operations (eg: in declarative applets).

The new methods are called (dis)associateItem to prevent disambiguation issues.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with a QML plasmoid in plasmoidviewer.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/private/service_p.h <span style="color: \
grey">(8afef0b6f1ca8bfa11b271fd3b29bc033a94c9a5)</span></li>

 <li>plasma/service.h <span style="color: \
grey">(314909ba84702beb16a36208d1a3c058b1a20f77)</span></li>

 <li>plasma/service.cpp <span style="color: \
grey">(3846e817d013cf26e2dcf57c5fd86783f061bb13)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104760/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 