--===============5325153496125756731== Content-Type: multipart/alternative; boundary="===============1658297281079532341==" --===============1658297281079532341== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104760/ ----------------------------------------------------------- (Updated April 27, 2012, 8:47 p.m.) Review request for Plasma. Changes ------- Rename the new methods to associateItem/disassociateItem, since otherwise t= he scriptengine can't disambiguate when passed a QGraphicsWidget. Description (updated) ------- Allow QML items to be associated with operations in Plasma::Service QML items derive from QGraphicsObject, but not QGraphicsWidget. We actually only need QGraphicsObject (for the enabled property). This allows QML items to be associated with operations (eg: in declarative = applets). The new methods are called (dis)associateItem to prevent disambiguation iss= ues. Diffs (updated) ----- plasma/private/service_p.h 8afef0b6f1ca8bfa11b271fd3b29bc033a94c9a5 = plasma/service.h 314909ba84702beb16a36208d1a3c058b1a20f77 = plasma/service.cpp 3846e817d013cf26e2dcf57c5fd86783f061bb13 = Diff: http://git.reviewboard.kde.org/r/104760/diff/ Testing ------- Tested with a QML plasmoid in plasmoidviewer. Thanks, Alex Merry --===============1658297281079532341== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104760/

Review request for Plasma.
By Alex Merry.

Updated April 27, 2012, 8:47 p.m.

Changes 
Rename the new methods to associateItem/disassociateItem, si=
nce otherwise the scriptengine can't disambiguate when passed a QGraphi=
csWidget.

Descripti= on (updated)

Allow QML items to be associated with operations in Plasma::=
Service

QML items derive from QGraphicsObject, but not QGraphicsWidget.  We
actually only need QGraphicsObject (for the enabled property).

This allows QML items to be associated with operations (eg: in declarative =
applets).

The new methods are called (dis)associateItem to prevent disambiguation iss=
ues.

Testing <= /h1> 
Tested with a QML plasmoid in plasmoidviewer.

Diffs= (updated)

  • plasma/private/service_p.h (8afef0b6f1ca8b= fa11b271fd3b29bc033a94c9a5)
  • plasma/service.h (314909ba84702beb16a36208= d1a3c058b1a20f77)
  • plasma/service.cpp (3846e817d013cf26e2dcf5= 7c5fd86783f061bb13)

View Diff
--===============1658297281079532341==-- --===============5325153496125756731== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5325153496125756731==--