[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-04-15 9:10:29
Message-ID: 20120415091029.23582.95884 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104603/#review12459
-----------------------------------------------------------
FTR: KWin's desktop change OSD has been completely rewritten in QML and I would \
highly suggest that it should also this OSD should use QML.
- Martin Gräßlin
On April 15, 2012, 8:10 a.m., makis marimpis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104603/
> -----------------------------------------------------------
>
> (Updated April 15, 2012, 8:10 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Closes: http://bugs.kde.org/show_bug.cgi?id=265456
> Partialy closes: https://bugs.kde.org/show_bug.cgi?id=295410
>
> "On screen display" notification when changing activities.
> Displays the user icon and the name.
>
> It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand.
>
> This could be as well implemented on KWin, but i did as a kamd plugin for fun :P.
>
> For the time being i think it is not correct to force such plugin (it would be cool \
> is kamd's plugins were managed via systemsettings) without an option to \
> enable/disable, but anyways, here goes nothing. Code cleanup is somewhat needed.
>
> This addresses bugs 265456 and 295410.
> http://bugs.kde.org/show_bug.cgi?id=265456
> http://bugs.kde.org/show_bug.cgi?id=295410
>
>
> Diffs
> -----
>
> service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858
> service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION
> service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION
> service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION
> service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION
> service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION
> service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREATION
> service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CREATION
> service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop \
> PRE-CREATION
> Diff: http://git.reviewboard.kde.org/r/104603/diff/
>
>
> Testing
> -------
>
> Changed activities and it works.
>
>
> Screenshots
> -----------
>
> without kwin effects
> http://git.reviewboard.kde.org/r/104603/s/531/
> with kwin effects
> http://git.reviewboard.kde.org/r/104603/s/532/
> after kwin effects disabledd (possible bug)
> http://git.reviewboard.kde.org/r/104603/s/533/
>
>
> Thanks,
>
> makis marimpis
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104603/">http://git.reviewboard.kde.org/r/104603/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FTR: KWin's desktop \
change OSD has been completely rewritten in QML and I would highly suggest that it \
should also this OSD should use QML.</pre> <br />
<p>- Martin</p>
<br />
<p>On April 15th, 2012, 8:10 a.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 8:10 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Closes: http://bugs.kde.org/show_bug.cgi?id=265456 Partialy closes: \
https://bugs.kde.org/show_bug.cgi?id=295410
"On screen display" notification when changing activities.
Displays the user icon and the name.
It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand.
This could be as well implemented on KWin, but i did as a kamd plugin for fun :P.
For the time being i think it is not correct to force such plugin (it would be cool \
is kamd's plugins were managed via systemsettings) without an option to \
enable/disable, but anyways, here goes nothing. Code cleanup is somewhat \
needed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed activities and it works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265456">265456</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=295410">295410</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/plugins/CMakeLists.txt <span style="color: \
grey">(3e965c0a201a7eee2c9868fcf163cf55af636858)</span></li>
<li>service/plugins/activitychangedosd/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangeditem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangeditem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosd.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosd.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosdplugin.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitychangedosdplugin.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>service/plugins/activitychangedosd/activitymanager-plugin-activitychangedosd.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104603/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104603/s/531/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/without_kwin_effects_400x100.jpeg" \
style="border: 1px black solid;" alt="without kwin effects" /></a>
<a href="http://git.reviewboard.kde.org/r/104603/s/532/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/with_kwin_effects_400x100.jpeg" \
style="border: 1px black solid;" alt="with kwin effects" /></a>
<a href="http://git.reviewboard.kde.org/r/104603/s/533/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/after_kwin_effects_disabled_400x100.jpeg" \
style="border: 1px black solid;" alt="after kwin effects disabledd (possible bug)" \
/></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic