From kde-panel-devel Sun Apr 15 09:10:29 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Sun, 15 Apr 2012 09:10:29 +0000 To: kde-panel-devel Subject: Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display Message-Id: <20120415091029.23582.95884 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133448114713718 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1204333665382048703==" --===============1204333665382048703== Content-Type: multipart/alternative; boundary="===============5539219409750712777==" --===============5539219409750712777== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104603/#review12459 ----------------------------------------------------------- FTR: KWin's desktop change OSD has been completely rewritten in QML and I w= ould highly suggest that it should also this OSD should use QML. - Martin Gr=C3=A4=C3=9Flin On April 15, 2012, 8:10 a.m., makis marimpis wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104603/ > ----------------------------------------------------------- > = > (Updated April 15, 2012, 8:10 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Closes: http://bugs.kde.org/show_bug.cgi?id=3D265456 > Partialy closes: https://bugs.kde.org/show_bug.cgi?id=3D295410 > = > "On screen display" notification when changing activities. > Displays the user icon and the name. > = > It is heavily based on KWin's DesktopChangedOSD and KRunner's Quicksand. > = > This could be as well implemented on KWin, but i did as a kamd plugin for= fun :P. > = > For the time being i think it is not correct to force such plugin (it wou= ld be cool is kamd's plugins were managed via systemsettings) without an op= tion to enable/disable, but anyways, here goes nothing. Code cleanup is som= ewhat needed. > = > = > This addresses bugs 265456 and 295410. > http://bugs.kde.org/show_bug.cgi?id=3D265456 > http://bugs.kde.org/show_bug.cgi?id=3D295410 > = > = > Diffs > ----- > = > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 = > service/plugins/activitychangedosd/CMakeLists.txt PRE-CREATION = > service/plugins/activitychangedosd/activitychangeditem.h PRE-CREATION = > service/plugins/activitychangedosd/activitychangeditem.cpp PRE-CREATION = > service/plugins/activitychangedosd/activitychangedosd.h PRE-CREATION = > service/plugins/activitychangedosd/activitychangedosd.cpp PRE-CREATION = > service/plugins/activitychangedosd/activitychangedosdplugin.h PRE-CREAT= ION = > service/plugins/activitychangedosd/activitychangedosdplugin.cpp PRE-CRE= ATION = > service/plugins/activitychangedosd/activitymanager-plugin-activitychang= edosd.desktop PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/104603/diff/ > = > = > Testing > ------- > = > Changed activities and it works. > = > = > Screenshots > ----------- > = > without kwin effects > http://git.reviewboard.kde.org/r/104603/s/531/ > with kwin effects > http://git.reviewboard.kde.org/r/104603/s/532/ > after kwin effects disabledd (possible bug) > http://git.reviewboard.kde.org/r/104603/s/533/ > = > = > Thanks, > = > makis marimpis > = > --===============5539219409750712777== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104603/ 

FTR: KWin&=
#39;s desktop change OSD has been completely rewritten in QML and I would h=
ighly suggest that it should also this OSD should use QML.

- Martin


On April 15th, 2012, 8:10 a.m., makis marimpis wrote:

Review request for Plasma.
By makis marimpis.

Updated April 15, 2012, 8:10 a.m.

Descripti= on 

Closes: http://bugs.kde.org/show_bug.cgi?id=3D265456
Partialy closes: https://bugs.kde.org/show_bug.cgi?id=3D295410

"On screen display" notification when changing activities.
Displays the user icon and the name.

It is heavily based on KWin's DesktopChangedOSD and KRunner's Quick=
sand.

This could be as well implemented on KWin, but i did as a kamd plugin for f=
un :P.

For the time being i think it is not correct to force such plugin (it would=
 be cool is kamd's plugins were managed via systemsettings) without an =
option to enable/disable, but anyways, here goes nothing. Code cleanup is s=
omewhat needed.

Testing <= /h1> 
Changed activities and it works.
Bugs: 265456, = 295410

Diffs=

  • service/plugins/CMakeLists.txt (3e965c0a20= 1a7eee2c9868fcf163cf55af636858)
  • service/plugins/activitychangedosd/CMakeLists.txt (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangeditem.h (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangeditem.cpp (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangedosd.h (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangedosd.cpp (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangedosdplugin.h (PRE-CREATION)
  • service/plugins/activitychangedosd/activitychangedosdplugin.cpp (PRE-CREATION)
  • service/plugins/activitychangedosd/activitymanager-plugin-activitychan= gedosd.desktop (PRE-CREATION)

View Diff

Screensho= ts

3D"without 3D"with 3D"after=
--===============5539219409750712777==-- --===============1204333665382048703== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1204333665382048703==--