'Re: Review Request: Remove the signals from the constant properties'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Remove the signals from the constant properties
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-04-13 16:39:37
Message-ID: 20120413163937.31408.91827 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104475/#review12401
-----------------------------------------------------------

Ship it!

- Marco Martin

On April 3, 2012, 11:10 a.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104475/
> -----------------------------------------------------------
> =

> (Updated April 3, 2012, 11:10 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Hello,
> =

> the KLocale QML bindings are almost ready(only two properties doesn't wor=
k) except from this issue.
> There are some properties which doesn't have a setter so I can't emit the=
ir signals. Also the KLocale/KCalendarSystem
> doesn't derive from QObject so I can't do any signal forward. Moreover th=
e global config files doesn't give me any relative
> information regarding my issue. So I decided to remove the signals and ma=
ke the properties constant. What do you think?
> =

> P.S.After I solve this issue I will add review for the whole branch.
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/locale/calendarsystem.h 184a37e =

>   plasma/declarativeimports/locale/locale.h f52761e =

>   plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml=
 0e61bb3 =

> =

> Diff: http://git.reviewboard.kde.org/r/104475/diff/
> =

> =

> Testing
> -------
> =

> everything works
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliwkas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104475/">http://git.reviewboard.kde.org/r/104475/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Marco</p>

<br />
<p>On April 3rd, 2012, 11:10 a.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated April 3, 2012, 11:10 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

the KLocale QML bindings are almost ready(only two properties doesn&#39;t work) \
except from this issue. There are some properties which doesn&#39;t have a setter so \
I can&#39;t emit their signals. Also the KLocale/KCalendarSystem doesn&#39;t derive \
from QObject so I can&#39;t do any signal forward. Moreover the global config files \
doesn&#39;t give me any relative information regarding my issue. So I decided to \
remove the signals and make the properties constant. What do you think?

P.S.After I solve this issue I will add review for the whole branch.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">everything works</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/locale/calendarsystem.h <span style="color: \
grey">(184a37e)</span></li>

 <li>plasma/declarativeimports/locale/locale.h <span style="color: \
grey">(f52761e)</span></li>

 <li>plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml <span \
style="color: grey">(0e61bb3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104475/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 