From kde-panel-devel Fri Apr 13 16:39:37 2012 From: "Marco Martin" Date: Fri, 13 Apr 2012 16:39:37 +0000 To: kde-panel-devel Subject: Re: Review Request: Remove the signals from the constant properties Message-Id: <20120413163937.31408.91827 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133433529405914 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9139134630546469845==" --===============9139134630546469845== Content-Type: multipart/alternative; boundary="===============2739187878442931547==" --===============2739187878442931547== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104475/#review12401 ----------------------------------------------------------- Ship it! - Marco Martin On April 3, 2012, 11:10 a.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104475/ > ----------------------------------------------------------- > = > (Updated April 3, 2012, 11:10 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Hello, > = > the KLocale QML bindings are almost ready(only two properties doesn't wor= k) except from this issue. > There are some properties which doesn't have a setter so I can't emit the= ir signals. Also the KLocale/KCalendarSystem > doesn't derive from QObject so I can't do any signal forward. Moreover th= e global config files doesn't give me any relative > information regarding my issue. So I decided to remove the signals and ma= ke the properties constant. What do you think? > = > P.S.After I solve this issue I will add review for the whole branch. > = > = > Diffs > ----- > = > plasma/declarativeimports/locale/calendarsystem.h 184a37e = > plasma/declarativeimports/locale/locale.h f52761e = > plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml= 0e61bb3 = > = > Diff: http://git.reviewboard.kde.org/r/104475/diff/ > = > = > Testing > ------- > = > everything works > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============2739187878442931547== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104475/

Ship it!

- Marco


On April 3rd, 2012, 11:10 a.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated April 3, 2012, 11:10 a.m.

Descripti= on 

Hello,

the KLocale QML bindings are almost ready(only two properties doesn't w=
ork) except from this issue.
There are some properties which doesn't have a setter so I can't em=
it their signals. Also the KLocale/KCalendarSystem
doesn't derive from QObject so I can't do any signal forward. Moreo=
ver the global config files doesn't give me any relative
information regarding my issue. So I decided to remove the signals and make=
 the properties constant. What do you think?

P.S.After I solve this issue I will add review for the whole branch.

Testing <= /h1> 
everything works

Diffs=

  • plasma/declarativeimports/locale/calendarsystem.h (184a37e)
  • plasma/declarativeimports/locale/locale.h = (f52761e)
  • plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qm= l (0e61bb3)

View Diff
--===============2739187878442931547==-- --===============9139134630546469845== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9139134630546469845==--