[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Merge the final and fixed QML battery monitor to master.
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-04-02 12:25:19
Message-ID: 20120402122519.1559.61056 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/#review12114
-----------------------------------------------------------
Ship it!
Looking good now, thanks a lot for your patience!
I'm getting this TypeError still, haven't looked into the reason behind it:
file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/conte=
nts/ui/batterymonitor.qml:77: TypeError: Result of expression 'pmSource.dat=
a["PowerDevil"]' [undefined] is not an object.
I propose to merge it into master now. There's still a bit of polishing pos=
sible (margins, for example), but we can easily do those when it's in maste=
r.
- Sebastian K=C3=BCgler
On March 23, 2012, 6:20 p.m., Viranch Mehta wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104226/
> -----------------------------------------------------------
> =
> (Updated March 23, 2012, 6:20 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> I fixed the QML battery monitor to be fairly usable and this diff merges =
it to master.
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/CMakeLists.txt 2dedcb2 =
> plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION =
> plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION =
> plasma/generic/applets/batterymonitor/README.txt PRE-CREATION =
> plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-=
CREATION =
> plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION =
> plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREA=
TION =
> plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CR=
EATION =
> plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-C=
REATION =
> plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PR=
E-CREATION =
> plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATIO=
N =
> plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION =
> plasma/generic/dataengines/powermanagement/powermanagementengine.h 2064=
2c2 =
> plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 55=
72fcb =
> plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 =
> plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205b=
b0 =
> plasma/generic/dataengines/powermanagement/powermanagementservice.opera=
tions ad1301f =
> =
> Diff: http://git.reviewboard.kde.org/r/104226/diff/
> =
> =
> Testing
> -------
> =
> Applet and dataengine both tested and work fine.
> =
> =
> Screenshots
> -----------
> =
> with top right graphic in the popup
> http://git.reviewboard.kde.org/r/104226/s/487/
> =
> =
> Thanks,
> =
> Viranch Mehta
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104226/">http://git.reviewboard.kde.org/r/104226/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking good now, thanks \
a lot for your patience!
I'm getting this TypeError still, haven't looked into the reason behind it:
file:///home/sebas/kdesvn/install/share/apps/plasma/plasmoids/battery/contents/ui/batterymonitor.qml:77: \
TypeError: Result of expression 'pmSource.data["PowerDevil"]' \
[undefined] is not an object.
I propose to merge it into master now. There's still a bit of polishing possible \
(margins, for example), but we can easily do those when it's in master.</pre> \
<br />
<p>- Sebastian</p>
<br />
<p>On March 23rd, 2012, 6:20 p.m., Viranch Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Viranch Mehta.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I fixed the QML battery monitor to be fairly usable and this diff merges \
it to master.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applet and dataengine both tested and work fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(2dedcb2)</span></li>
<li>plasma/generic/applets/batterymonitor/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/README.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/battery-oxygen.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/config/main.xml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/batterymonitor/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span \
style="color: grey">(20642c2)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span \
style="color: grey">(5572fcb)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span \
style="color: grey">(2c32015)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span \
style="color: grey">(e205bb0)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
<span style="color: grey">(ad1301f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104226/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104226/s/487/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/23/battery1_400x100.png" \
style="border: 1px black solid;" alt="with top right graphic in the popup" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic