'Re: Review Request: Merge the final and fixed QML battery monitor to master.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Merge the final and fixed QML battery monitor to master.
From:       "Viranch Mehta" <viranch.mehta () gmail ! com>
Date:       2012-03-23 18:20:22
Message-ID: 20120323182022.16840.11833 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104226/
-----------------------------------------------------------

(Updated March 23, 2012, 6:20 p.m.)

Review request for Plasma.

Changes
-------

Screenshot update, showing the top right battery icon in the popup

Description
-------

I fixed the QML battery monitor to be fairly usable and this diff merges it=
 to master.

Diffs
-----

  plasma/generic/applets/CMakeLists.txt 2dedcb2 =

  plasma/generic/applets/batterymonitor/CMakeLists.txt PRE-CREATION =

  plasma/generic/applets/batterymonitor/Messages.sh PRE-CREATION =

  plasma/generic/applets/batterymonitor/README.txt PRE-CREATION =

  plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz PRE-CR=
EATION =

  plasma/generic/applets/batterymonitor/battery-oxygen.svgz PRE-CREATION =

  plasma/generic/applets/batterymonitor/contents/config/main.xml PRE-CREATI=
ON =

  plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml PRE-CREA=
TION =

  plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml PRE-CRE=
ATION =

  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml PRE-=
CREATION =

  plasma/generic/applets/batterymonitor/contents/ui/config.ui PRE-CREATION =

  plasma/generic/applets/batterymonitor/metadata.desktop PRE-CREATION =

  plasma/generic/dataengines/powermanagement/powermanagementengine.h 20642c=
2 =

  plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 5572=
fcb =

  plasma/generic/dataengines/powermanagement/powermanagementjob.h 2c32015 =

  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp e205bb0 =

  plasma/generic/dataengines/powermanagement/powermanagementservice.operati=
ons ad1301f =

Diff: http://git.reviewboard.kde.org/r/104226/diff/

Testing
-------

Applet and dataengine both tested and work fine.

Screenshots (updated)
-----------

with top right graphic in the popup
  http://git.reviewboard.kde.org/r/104226/s/487/

Thanks,

Viranch Mehta

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104226/">http://git.reviewboard.kde.org/r/104226/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Viranch Mehta.</div>

<p style="color: grey;"><i>Updated March 23, 2012, 6:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Screenshot update, showing the top right battery icon in the popup</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I fixed the QML battery monitor to be fairly usable and this diff merges \
it to master.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Applet and dataengine both tested and work fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/CMakeLists.txt <span style="color: \
grey">(2dedcb2)</span></li>

 <li>plasma/generic/applets/batterymonitor/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/README.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/battery-oxygen-inkscape.svgz <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/battery-oxygen.svgz <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/config/main.xml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/IconButton.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/applets/batterymonitor/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span \
style="color: grey">(20642c2)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span \
style="color: grey">(5572fcb)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span \
style="color: grey">(2c32015)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span \
style="color: grey">(e205bb0)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
<span style="color: grey">(ad1301f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104226/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots \
(updated)</h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/104226/s/487/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/23/battery1_400x100.png" \
style="border: 1px black solid;" alt="with top right graphic in the popup" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 