[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Hide action buttons at certain icon sizes
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-27 6:52:20
Message-ID: 20120327065220.11816.34669 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104413/#review11896
-----------------------------------------------------------
This review has been submitted with commit 141734215130c06073fc831c288f2ad6e3871645 \
by Ignat Semenov to branch master.
- Commit Hook
On March 26, 2012, 12:22 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104413/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 12:22 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.
>
>
> Description
> -------
>
> This patch disables action icons if they cover the actual icon. Thus, tthe buttons \
> being enabled depends on the grid size, the icon size and the svg margin size.
> I've tried a lot of different approaches in order to write the shortest and most \
> transparent code, hope the current one is fine from this perspective. Please pay \
> attention to design and incapsulation issues, I'm not a good designer at all.
>
> This addresses bug 268641.
> http://bugs.kde.org/show_bug.cgi?id=268641
>
>
> Diffs
> -----
>
> plasma/applets/folderview/actionoverlay.h e7c1982
> plasma/applets/folderview/actionoverlay.cpp 4dd1975
> plasma/applets/folderview/iconview.h c76b4f4
> plasma/applets/folderview/iconview.cpp 56f1eb8
>
> Diff: http://git.reviewboard.kde.org/r/104413/diff/
>
>
> Testing
> -------
>
> Tested, works.
>
> I still wonder, however, why we can't have a checkbox to disable the dreaded "+" \
> button.. although the patch submitted in thei review request should go in \
> regardless of such a checkbox being added because at some icon sizes, the action \
> icons are a plain annoyance, indeed.
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104413/">http://git.reviewboard.kde.org/r/104413/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 141734215130c06073fc831c288f2ad6e3871645 by Ignat Semenov to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 26th, 2012, 12:22 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated March 26, 2012, 12:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch disables action icons if they cover the actual icon. Thus, \
tthe buttons being enabled depends on the grid size, the icon size and the svg margin \
size.
I've tried a lot of different approaches in order to write the shortest and most \
transparent code, hope the current one is fine from this perspective. Please pay \
attention to design and incapsulation issues, I'm not a good designer at \
all.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.
I still wonder, however, why we can't have a checkbox to disable the dreaded \
"+" button.. although the patch submitted in thei review request should go \
in regardless of such a checkbox being added because at some icon sizes, the action \
icons are a plain annoyance, indeed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268641">268641</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/actionoverlay.h <span style="color: \
grey">(e7c1982)</span></li>
<li>plasma/applets/folderview/actionoverlay.cpp <span style="color: \
grey">(4dd1975)</span></li>
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(c76b4f4)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(56f1eb8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104413/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic