[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEve
From: "Ignat Semenov" <13thguards () gmail ! com>
Date: 2012-03-22 13:07:31
Message-ID: 20120322130731.30875.86486 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103822/
-----------------------------------------------------------
(Updated March 22, 2012, 1:07 p.m.)
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Changes
-------
Fixed a one-line issue where multiple selection would not be repainted with=
single-click settings.
In mouseReleaseEvent(), in the single click branch, we should not reset the=
selection as this will result in the code in the following if clause not b=
eing executed and the selection not repainted.
Now this is ready to go. Sorry for the delay, I'm cleaning up my old reques=
ts now, finally.
Description
-------
This patch aims to save some repaints in FolderView::IconView on the variou=
s mouseEvent()'s by choosing what to repaint in a bit smarter way.
Diffs (updated)
-----
plasma/applets/folderview/iconview.h 12e93b3 =
plasma/applets/folderview/iconview.cpp 5c4e086 =
Diff: http://git.reviewboard.kde.org/r/103822/diff/
Testing
-------
Testing done against master, seems to behave indentically.
Thanks,
Ignat Semenov
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103822/">http://git.reviewboard.kde.org/r/103822/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated March 22, 2012, 1:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed a one-line issue where multiple selection would not be repainted \
with single-click settings.
In mouseReleaseEvent(), in the single click branch, we should not reset the selection \
as this will result in the code in the following if clause not being executed and the \
selection not repainted.
Now this is ready to go. Sorry for the delay, I'm cleaning up my old requests \
now, finally.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch aims to save some repaints in FolderView::IconView on the \
various mouseEvent()'s by choosing what to repaint in a bit smarter way.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing done against master, seems to behave indentically.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(12e93b3)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(5c4e086)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103822/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic