[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEve
From: "Ignat Semenov" <13thguards () gmail ! com>
Date: 2012-02-05 19:38:43
Message-ID: 20120205193843.8730.32340 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2012, 6:46 p.m., Fredrik Höglund wrote:
> > Aside from some minor nitpicks, it looks good.
I forgot to add that I couldn't optimize the right click path in mousePressEvent(). \
The problem is that in order to get the containment context menu, the RMB press event \
is propagated to the parent and triggers an unconditional repaint. I confirmed this \
behavior by removing all the markAreaDirty() calls in that path - then view still \
repainted fine. Thus, a right click repaints the whole view, voiding the optimization \
of that code path. Any ideas?
The optimization in that branch is there just for the sake completeness - the view \
will repaint fully anyway.
> On Feb. 5, 2012, 6:46 p.m., Fredrik Höglund wrote:
> > plasma/applets/folderview/iconview.cpp, line 1803
> > <http://git.reviewboard.kde.org/r/103822/diff/1/?file=48118#file48118line1803>
> >
> > Make these const. There is also a whitespace error on this line.
Sorry, my fault. I will make a big poster "const correctness and git diff --check" \
and place it on the wall above the desk ;)
> On Feb. 5, 2012, 6:46 p.m., Fredrik Höglund wrote:
> > plasma/applets/folderview/iconview.cpp, line 2605
> > <http://git.reviewboard.kde.org/r/103822/diff/1/?file=48118#file48118line2605>
> >
> > Change the name of this variable to 'rect'.
Indeed, it is not necessarily dirty. Copy-paste :)
- Ignat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103822/#review10360
-----------------------------------------------------------
On Jan. 29, 2012, 3:54 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103822/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2012, 3:54 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> -------
>
> This patch aims to save some repaints in FolderView::IconView on the various \
> mouseEvent()'s by choosing what to repaint in a bit smarter way.
>
> Diffs
> -----
>
> plasma/applets/folderview/iconview.h 66ccb98
> plasma/applets/folderview/iconview.cpp 5b0cd98
>
> Diff: http://git.reviewboard.kde.org/r/103822/diff/diff
>
>
> Testing
> -------
>
> Testing done against master, seems to behave indentically.
>
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103822/">http://git.reviewboard.kde.org/r/103822/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2012, 6:46 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Aside from some minor nitpicks, it looks good.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I forgot to add that I \
couldn't optimize the right click path in mousePressEvent(). The problem is that \
in order to get the containment context menu, the RMB press event is propagated to \
the parent and triggers an unconditional repaint. I confirmed this behavior by \
removing all the markAreaDirty() calls in that path - then view still repainted fine. \
Thus, a right click repaints the whole view, voiding the optimization of that code \
path. Any ideas?
The optimization in that branch is there just for the sake completeness - the view \
will repaint fully anyway.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2012, 6:46 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103822/diff/1/?file=48118#file48118line1803" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/applets/folderview/iconview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
IconView::mousePressEvent(QGraphicsSceneMouseEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1803</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QRect</span> <span class="n">dirtyRect</span> <span \
class="o">=</span><span class="n">selectedItemsBoundingRect</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make these const. There \
is also a whitespace error on this line.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, my \
fault. I will make a big poster "const correctness and git diff --check" \
and place it on the wall above the desk ;)</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2012, 6:46 p.m., <b>Fredrik \
Höglund</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103822/diff/1/?file=48118#file48118line2605" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/applets/folderview/iconview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
IconView::selectIconsInArea(const QRect &area, const QPoint \
&finalPos)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">2595</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRect</span> <span class="n">dirtyRect</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">2605</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QRect</span> <span \
class="n">dirtyRect</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change the name of this \
variable to 'rect'.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed, it \
is not necessarily dirty. Copy-paste :)</pre> <br />
<p>- Ignat</p>
<br />
<p>On January 29th, 2012, 3:54 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 3:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch aims to save some repaints in FolderView::IconView on the \
various mouseEvent()'s by choosing what to repaint in a bit smarter way.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing done against master, seems to behave indentically.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(66ccb98)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(5b0cd98)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103822/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic