[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix collapsed folderview in panels
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-10 20:33:52
Message-ID: 20120210203352.15998.98930 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103915/#review10496
-----------------------------------------------------------
This review has been submitted with commit a8694a6d733f9fc8f1a08256826d65a6bef1720b \
by Ignat Semenov to branch KDE/4.8.
- Commit Hook
On Feb. 10, 2012, 7:16 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103915/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2012, 7:16 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Fix folderview behavior in panels with regard to the collapsed mode.
>
> 1)Keep it small like Trash or Show desktop / Dashboard (ConstrainedSquare, \
> minimumSize & sizeHint - code taken from Trash, which behaves properly when in a \
> panel with regard to scaling). 2)Update icon size on panel icon size change.
> 3)No duplicates - if (m_iconWidget) check - the absence of such a check resulted \
> in Really Weird(TM) things going on, like duplicates or ghost folderviews.
>
> This addresses bug 244557.
> http://bugs.kde.org/show_bug.cgi?id=244557
>
>
> Diffs
> -----
>
> plasma/applets/folderview/folderview.cpp c3b6e2a
>
> Diff: http://git.reviewboard.kde.org/r/103915/diff/diff
>
>
> Testing
> -------
>
> Tested the hell out of it:dragged the panel around the screen on all the 4 screen \
> edges - no problems noticed. Changed Panel icon size in the Icons KCM, updates on \
> the fly.
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103915/">http://git.reviewboard.kde.org/r/103915/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit a8694a6d733f9fc8f1a08256826d65a6bef1720b by Ignat Semenov to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 10th, 2012, 7:16 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2012, 7:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix folderview behavior in panels with regard to the collapsed mode.
1)Keep it small like Trash or Show desktop / Dashboard (ConstrainedSquare, \
minimumSize & sizeHint - code taken from Trash, which behaves properly when in a \
panel with regard to scaling). 2)Update icon size on panel icon size change.
3)No duplicates - if (m_iconWidget) check - the absence of such a check resulted in \
Really Weird(TM) things going on, like duplicates or ghost folderviews.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested the hell out of it:dragged the panel around the screen on all the \
4 screen edges - no problems noticed. Changed Panel icon size in the Icons KCM, \
updates on the fly.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=244557">244557</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(c3b6e2a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103915/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic