[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma HDD Activity/IO system monitor applet creation
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-02-07 18:22:28
Message-ID: 20120207182228.18139.10139 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103878/#review10400
-----------------------------------------------------------
Ship it!
seems well done
- Marco Martin
On Feb. 6, 2012, 4:52 a.m., Shaun Reich wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103878/
> -----------------------------------------------------------
> =
> (Updated Feb. 6, 2012, 4:52 a.m.)
> =
> =
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> =
> =
> Description
> -------
> =
> Made a plasma applet that monitors hard disk I/O, aka throughput/activity.
> =
> Planning on merging it into master workspace, as the other sysmon applets=
are there, and hdd activity is actually a really common request.
> =
> it should be Most Probably Totally Bug Free=E2=84=A2 as well. though i'm =
having difficulties testing the case for when it's in the panel, but i can =
test & fix once it gets merged easily.
> =
> I apologize for how nasty the diff looks...i'm surprised reviewboard does=
n't have an ability to just upload a file and diff it against nothing.
> =
> a lot of the bugs related to this applet and the other applets, are due t=
o the main base class that all of them derive from, so i will fix more of t=
hat/those soon as well (i've already fixed quite a few of them).
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/system-monitor/CMakeLists.txt 0f74eb6 =
> plasma/generic/applets/system-monitor/hdd-activity-config.ui e641c8a =
> plasma/generic/applets/system-monitor/hdd_activity-config.ui PRE-CREATI=
ON =
> plasma/generic/applets/system-monitor/hdd_activity.h f74af85 =
> plasma/generic/applets/system-monitor/hdd_activity.cpp 5762d6d =
> plasma/generic/applets/system-monitor/plasma-applet-sm_hdd_activity.des=
ktop d3bb6b6 =
> =
> Diff: http://git.reviewboard.kde.org/r/103878/diff/diff
> =
> =
> Testing
> -------
> =
> 42
> =
> =
> Thanks,
> =
> Shaun Reich
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103878/">http://git.reviewboard.kde.org/r/103878/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems well done</pre> \
<br />
<p>- Marco</p>
<br />
<p>On February 6th, 2012, 4:52 a.m., Shaun Reich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Shaun Reich.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2012, 4:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Made a plasma applet that monitors hard disk I/O, aka \
throughput/activity.
Planning on merging it into master workspace, as the other sysmon applets are there, \
and hdd activity is actually a really common request.
it should be Most Probably Totally Bug Free™ as well. though i'm having \
difficulties testing the case for when it's in the panel, but i can test & \
fix once it gets merged easily.
I apologize for how nasty the diff looks...i'm surprised reviewboard doesn't \
have an ability to just upload a file and diff it against nothing.
a lot of the bugs related to this applet and the other applets, are due to the main \
base class that all of them derive from, so i will fix more of that/those soon as \
well (i've already fixed quite a few of them).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">42</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/system-monitor/CMakeLists.txt <span style="color: \
grey">(0f74eb6)</span></li>
<li>plasma/generic/applets/system-monitor/hdd-activity-config.ui <span style="color: \
grey">(e641c8a)</span></li>
<li>plasma/generic/applets/system-monitor/hdd_activity-config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/applets/system-monitor/hdd_activity.h <span style="color: \
grey">(f74af85)</span></li>
<li>plasma/generic/applets/system-monitor/hdd_activity.cpp <span style="color: \
grey">(5762d6d)</span></li>
<li>plasma/generic/applets/system-monitor/plasma-applet-sm_hdd_activity.desktop \
<span style="color: grey">(d3bb6b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103878/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic