[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add Corona::addContainment feature to plasma-previewer
From: "Shaun Reich" <shaun.reich () kdemail ! net>
Date: 2012-02-06 14:58:51
Message-ID: 20120206145851.20664.58479 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103214/#review10372
-----------------------------------------------------------
patch looks great. thanks.
just some minor nitpicking with coding style...
previewer/plasmoid/plasmoidview.h
<http://git.reviewboard.kde.org/r/103214/#comment8543>
need space after comma in &name,
previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8542>
need space after comma in QString &containment,const
previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8541>
need space between operators (in this case, +)
previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8540>
need space between ( in if(
- Shaun Reich
On Nov. 23, 2011, 10:29 a.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103214/
> -----------------------------------------------------------
> =
> (Updated Nov. 23, 2011, 10:29 a.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> Hello
> =
> This patch is add the containment feature to the plasma-previewer.
> =
> =
> Diffs
> -----
> =
> previewer/plasmoid/plasmoidview.h 6ffd330 =
> previewer/plasmoid/plasmoidview.cpp 3d40d48 =
> previewer/plasmoid/test/main.cpp 609b595 =
> =
> Diff: http://git.reviewboard.kde.org/r/103214/diff/diff
> =
> =
> Testing
> -------
> =
> plasmate compiles fine and plasma-previewer -c behaves like the plasmoidv=
iewer -c....
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103214/">http://git.reviewboard.kde.org/r/103214/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">patch looks great. \
thanks.
just some minor nitpicking with coding style...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103214/diff/1/?file=41848#file41848line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">previewer/plasmoid/plasmoidview.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
PlasmoidView : public QGraphicsView</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">42</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">addApplet</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QString</span> <span \
class="o">&</span><span class="n">name</span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QVariantList</span> <span \
class="o">&</span><span class="n">args</span> <span class="o">=</span> <span \
class="n">QVariantList</span><span class="p">());</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">addApplet</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QString</span> <span \
class="o">&</span><span class="n">name</span><span class="p"><span \
class="hl">,</span></span><span class="n"><span class="hl">QString</span></span><span \
class="hl"> </span><span class="o"><span class="hl">&</span></span><span \
class="n"><span class="hl">containment</span></span><span class="p">,</span> <span \
class="k">const</span> <span class="n">QVariantList</span> <span \
class="o">&</span><span class="n">args</span> <span class="o">=</span> <span \
class="n">QVariantList</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need space \
after comma in &name,</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103214/diff/1/?file=41849#file41849line120" \
style="color: black; font-weight: bold; text-decoration: \
underline;">previewer/plasmoid/plasmoidview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
PlasmoidView::hasContainmentStorageGroup() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">120</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> \
<span class="n">PlasmoidView</span><span class="o">::</span><span \
class="n">addApplet</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">name</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QVariantList</span> \
<span class="o">&</span><span class="n">args</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">120</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span \
class="n">PlasmoidView</span><span class="o">::</span><span \
class="n">addApplet</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">name</span><span \
class="p">,</span> <span class="n"><span class="hl">QString</span></span><span \
class="hl"> </span><span class="o"><span class="hl">&</span></span><span \
class="n"><span class="hl">containment</span></span><span class="p"><span \
class="hl">,</span></span><span class="k">const</span> <span \
class="n">QVariantList</span> <span class="o">&</span><span \
class="n">args</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need space \
after comma in QString &containment,const</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103214/diff/1/?file=41849#file41849line122" \
style="color: black; font-weight: bold; text-decoration: \
underline;">previewer/plasmoid/plasmoidview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
PlasmoidView::hasContainmentStorageGroup() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">122</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KService</span><span class="o">::</span><span class="n">List</span> <span \
class="n">offers</span> <span class="o">=</span> <span \
class="n">KServiceTypeTrader</span><span class="o">::</span><span \
class="n">self</span><span class="p">()</span><span class="o">-></span><span \
class="n">query</span><span class="p">(</span><span \
class="s">"Plasma/Containment"</span><span class="p">,</span> <span \
class="s">"[X-KDE-PluginInfo-Name] == '"</span> <span \
class="o">+</span> <span class="n">containment</span><span class="o">+</span><span \
class="s">"'"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need space \
between operators (in this case, +)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103214/diff/1/?file=41849#file41849line123" \
style="color: black; font-weight: bold; text-decoration: \
underline;">previewer/plasmoid/plasmoidview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
PlasmoidView::hasContainmentStorageGroup() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">123</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span><span class="p">(</span><span class="n">offers</span><span \
class="p">.</span><span class="n">count</span><span class="p">()</span> <span \
class="o">></span> <span class="mi">0</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">need space \
between ( in if(</pre> </div>
<br />
<p>- Shaun</p>
<br />
<p>On November 23rd, 2011, 10:29 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 23, 2011, 10:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello
This patch is add the containment feature to the plasma-previewer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasmate compiles fine and plasma-previewer -c behaves like the \
plasmoidviewer -c....</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>previewer/plasmoid/plasmoidview.h <span style="color: \
grey">(6ffd330)</span></li>
<li>previewer/plasmoid/plasmoidview.cpp <span style="color: \
grey">(3d40d48)</span></li>
<li>previewer/plasmoid/test/main.cpp <span style="color: grey">(609b595)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103214/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic