[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix plasma popup alignment
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-31 7:46:42
Message-ID: 20111231074642.11767.74900 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103595/#review9391
-----------------------------------------------------------
This review has been submitted with commit 1b7bc69d6d78e6a82b5664f1922a5656=
3a1fe0f4 by Nikita Churaev to branch KDE/4.8.
- Commit Hook
On Dec. 31, 2011, 5:18 a.m., Nikita Churaev wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103595/
> -----------------------------------------------------------
> =
> (Updated Dec. 31, 2011, 5:18 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Right-aligned popups are one pixel away from right edge of the screen and=
top-aligned popups (when the panel is on top) are one pixel inside panel. =
This is because the bug in QRect, where right() and bottom() value return v=
alue that is less than the true value by one. This is a feature-bug that Qt=
developers aren't going to fix because of compatiability reasons. My patch=
replaces rect.right() and rect.bottom() with (rect.x() + rect.width()) and=
(rect.y() + rect.height()) respectively.
> =
> =
> Diffs
> -----
> =
> plasma/corona.cpp 366a9df =
> =
> Diff: http://git.reviewboard.kde.org/r/103595/diff/diff
> =
> =
> Testing
> -------
> =
> Works as expected.
> =
> =
> Thanks,
> =
> Nikita Churaev
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103595/">http://git.reviewboard.kde.org/r/103595/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
1b7bc69d6d78e6a82b5664f1922a56563a1fe0f4 by Nikita Churaev to branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 31st, 2011, 5:18 a.m., Nikita Churaev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Nikita Churaev.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2011, 5:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right-aligned popups are one pixel away from \
right edge of the screen and top-aligned popups (when the panel is on top) are one pixel inside panel. \
This is because the bug in QRect, where right() and bottom() value return value that is less than the \
true value by one. This is a feature-bug that Qt developers aren't going to fix because of \
compatiability reasons. My patch replaces rect.right() and rect.bottom() with (rect.x() + rect.width()) \
and (rect.y() + rect.height()) respectively.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/corona.cpp <span style="color: grey">(366a9df)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103595/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic