From kde-panel-devel Sat Dec 31 07:46:42 2011 From: "Commit Hook" Date: Sat, 31 Dec 2011 07:46:42 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix plasma popup alignment Message-Id: <20111231074642.11767.74900 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132531776630029 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2237701510579630649==" --===============2237701510579630649== Content-Type: multipart/alternative; boundary="===============3039475204894671875==" --===============3039475204894671875== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103595/#review9391 ----------------------------------------------------------- This review has been submitted with commit 1b7bc69d6d78e6a82b5664f1922a5656= 3a1fe0f4 by Nikita Churaev to branch KDE/4.8. - Commit Hook On Dec. 31, 2011, 5:18 a.m., Nikita Churaev wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103595/ > ----------------------------------------------------------- > = > (Updated Dec. 31, 2011, 5:18 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Right-aligned popups are one pixel away from right edge of the screen and= top-aligned popups (when the panel is on top) are one pixel inside panel. = This is because the bug in QRect, where right() and bottom() value return v= alue that is less than the true value by one. This is a feature-bug that Qt= developers aren't going to fix because of compatiability reasons. My patch= replaces rect.right() and rect.bottom() with (rect.x() + rect.width()) and= (rect.y() + rect.height()) respectively. > = > = > Diffs > ----- > = > plasma/corona.cpp 366a9df = > = > Diff: http://git.reviewboard.kde.org/r/103595/diff/diff > = > = > Testing > ------- > = > Works as expected. > = > = > Thanks, > = > Nikita Churaev > = > --===============3039475204894671875== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103595/

This revie=
w has been submitted with commit 1b7bc69d6d78e6a82b5664f1922a56563a1fe0f4 b=
y Nikita Churaev to branch KDE/4.8.

- Commit

On December 31st, 2011, 5:18 a.m., Nikita Churaev wrote:

Review request for Plasma.

By Nikita Churaev.

Updated Dec. 31, 2011, 5:18 a.m.

Descripti= on

Right-aligned popups are one pixel away from right edge of t=
he screen and top-aligned popups (when the panel is on top) are one pixel i=
nside panel. This is because the bug in QRect, where right() and bottom() v=
alue return value that is less than the true value by one. This is a featur=
e-bug that Qt developers aren't going to fix because of compatiability =
reasons. My patch replaces rect.right() and rect.bottom() with (rect.x() + =
rect.width()) and (rect.y() + rect.height()) respectively.

Testing <= /h1>

Works as expected.

Diffs=

plasma/corona.cpp (366a9df)

View Diff

--===============3039475204894671875==-- --===============2237701510579630649== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2237701510579630649==--