'=?utf-8?q?Review_Request=3A_F=C3=AFx_two_little_bugs=3A_one_with_default_?='

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    =?utf-8?q?Review_Request=3A_F=C3=AFx_two_little_bugs=3A_one_with_default_?=
From:       "Nikita Churaev" <lamefun.x0r () gmail ! com>
Date:       2011-12-24 17:35:49
Message-ID: 20111224173549.28284.93668 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103529/
-----------------------------------------------------------

Review request for kdelibs and Plasma.

Description
-------

Contrast bug: KGlobalSettings::contrast() returns different default value t=
han KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color c=
ontrol module uses contrast(), so when the user first uses color settings, =
contrast appears to change.

Plasma popup bug: Right-aligned popups are one pixel away from right edge o=
f the screen and top-aligned popups (when panel is on top) are one pixel in=
side panel. This is because the bug in QRect, where right() and bottom() va=
lue return value that is less than the true value by one. This is a feature=
-bug that Qt developers aren't going to fix because of compatiability reaso=
ns. My patch just applies + 1 compensation to all expressions that use QRec=
t::right() and QRect::bottom().

Diffs
-----

  kdeui/kernel/kglobalsettings.cpp 819b314 =

  plasma/corona.cpp 366a9df =

Diff: http://git.reviewboard.kde.org/r/103529/diff/diff

Testing
-------

Thanks,

Nikita Churaev

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103529/">http://git.reviewboard.kde.org/r/103529/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Plasma.</div>
<div>By Nikita Churaev.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Contrast bug: KGlobalSettings::contrast() returns different default \
value than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color \
control module uses contrast(), so when the user first uses color settings, contrast \
appears to change.

Plasma popup bug: Right-aligned popups are one pixel away from right edge of the \
screen and top-aligned popups (when panel is on top) are one pixel inside panel. This \
is because the bug in QRect, where right() and bottom() value return value that is \
less than the true value by one. This is a feature-bug that Qt developers aren&#39;t \
going to fix because of compatiability reasons. My patch just applies + 1 \
compensation to all expressions that use QRect::right() and QRect::bottom().</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(819b314)</span></li>

 <li>plasma/corona.cpp <span style="color: grey">(366a9df)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103529/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 