--===============4104789966645066844== Content-Type: multipart/alternative; boundary="===============5428780638889308945==" --===============5428780638889308945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/ ----------------------------------------------------------- Review request for kdelibs and Plasma. Description ------- Contrast bug: KGlobalSettings::contrast() returns different default value t= han KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color c= ontrol module uses contrast(), so when the user first uses color settings, = contrast appears to change. Plasma popup bug: Right-aligned popups are one pixel away from right edge o= f the screen and top-aligned popups (when panel is on top) are one pixel in= side panel. This is because the bug in QRect, where right() and bottom() va= lue return value that is less than the true value by one. This is a feature= -bug that Qt developers aren't going to fix because of compatiability reaso= ns. My patch just applies + 1 compensation to all expressions that use QRec= t::right() and QRect::bottom(). Diffs ----- kdeui/kernel/kglobalsettings.cpp 819b314 = plasma/corona.cpp 366a9df = Diff: http://git.reviewboard.kde.org/r/103529/diff/diff Testing ------- Thanks, Nikita Churaev --===============5428780638889308945== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103529/

Review request for kdelibs and Plasma.
By Nikita Churaev.

Descripti= on 

Contrast bug: KGlobalSettings::contrast() returns different =
default value than KGlobalSettings::contrastF(). Oxygen uses contrastF() wh=
ile KDE color control module uses contrast(), so when the user first uses c=
olor settings, contrast appears to change.

Plasma popup bug: Right-aligned popups are one pixel away from right edge o=
f the screen and top-aligned popups (when panel is on top) are one pixel in=
side panel. This is because the bug in QRect, where right() and bottom() va=
lue return value that is less than the true value by one. This is a feature=
-bug that Qt developers aren't going to fix because of compatiability r=
easons. My patch just applies + 1 compensation to all expressions that use =
QRect::right() and QRect::bottom().

Diffs=

  • kdeui/kernel/kglobalsettings.cpp (819b314)=
  • plasma/corona.cpp (366a9df)

View Diff
--===============5428780638889308945==-- --===============4104789966645066844== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4104789966645066844==--