[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Reset time format upon user request
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2011-12-18 12:51:40
Message-ID: 20111218125140.20987.7649 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 18, 2011, 8:59 a.m., David Faure wrote:
> > SETTINGS_COMPLETION !? This has nothing to do with completion. How about adding a \
> > SETTINGS_LOCALE if that's what you need?
I am trying to minimize the number of patches needed to fix bug #289094. This review \
is patch number two and a third patch against kdelibs will be necessary to add \
KGlobalSettings::SETTINGS_COMPLETION in kglobalsettings.h. As I explained in my last \
review I have not found any better category.
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9031
-----------------------------------------------------------
On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103434/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2011, 9:13 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> The patch resets time format in digital clock plasmoid when the user changes the \
> 24h configuration in active-settings.
> The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering \
> if I should add this change to kdelibs instead of kde-workspace to avoid \
> duplicating code. Anyway, I wanted someone to review the code to see if there can \
> be any side effect.
>
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/clock.h 4aec3fd
> plasma/generic/applets/digital-clock/clock.cpp dd03692
>
> Diff: http://git.reviewboard.kde.org/r/103434/diff/diff
>
>
> Testing
> -------
>
> Works in Plasma Active. In Plasma Desktop kcmlocale does not call \
> KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does \
> not take effect. Other kcm modules (e.g. keyboard), call emitChange.
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103434/">http://git.reviewboard.kde.org/r/103434/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 18th, 2011, 8:59 a.m., <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">SETTINGS_COMPLETION !? This has nothing to do with completion. How about \
adding a SETTINGS_LOCALE if that's what you need?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am trying to minimize \
the number of patches needed to fix bug #289094. This review is patch number two and \
a third patch against kdelibs will be necessary to add \
KGlobalSettings::SETTINGS_COMPLETION in kglobalsettings.h. As I explained in my last \
review I have not found any better category.</pre> <br />
<p>- Lamarque Vieira</p>
<br />
<p>On December 16th, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch resets time format in digital clock plasmoid when the user \
changes the 24h configuration in active-settings.
The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering \
if I should add this change to kdelibs instead of kde-workspace to avoid duplicating \
code. Anyway, I wanted someone to review the code to see if there can be any side \
effect.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works in Plasma Active. In Plasma Desktop kcmlocale does not call \
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does \
not take effect. Other kcm modules (e.g. keyboard), call emitChange.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289094">289094</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/digital-clock/clock.h <span style="color: \
grey">(4aec3fd)</span></li>
<li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: \
grey">(dd03692)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103434/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic