[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Reset time format upon user request
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2011-12-18 12:51:25
Message-ID: 20111218125125.20987.87118 () vidsolbach ! de
[Download RAW message or body]
> On Dec. 18, 2011, 8:33 a.m., Aaron J. Seigo wrote:
> > plasma/generic/applets/digital-clock/clock.cpp, lines 100-102
> > <http://git.reviewboard.kde.org/r/103434/diff/2/?file=43561#file43561line100>
> >
> > this still realy ought to be done in klocale
Well, we could add a KLocale::commit() call to make any changes in KLocale visible to \
everybody. That call would replace the \
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, \
KGlobalSettings::SETTING_COMPLETION) that I am using in plasma-mobile. \
KLocale::commit() would use KGlobalSettings::self()->emitChange() internally, we can \
add KGlobalSetings::SETTINGS_LOCALE as David suggested below. There would be a \
private slot KLocale::updateChanges() listening to emitChange that would reparse the \
config files. Of course we will need to update the documentation about emitChange and \
that would not work for KDE SC <= 4.7.4 because of the addition of \
KGlobalSetings::SETTINGS_LOCALE.
In bug #289094 particular case the will be the problem of synchronizing \
KLocale::updateChanges() with the Clock::generatePixmap(); Clock::update() calls in \
the clock plasmoid. KLocale::updateChanges() would have to emit a signal to indicate \
the changes has been updated or the changes will take place only on the next update, \
which can take almost a minute in Plasma Active. The current patch update the time \
format instantaneously.
Another problem with this approach is that we cannot prevent anybody else from \
listening to KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, \
KGlobalSettings::SETTING_LOCALE). Hmmm we could add a private enum to accomodate \
KGlobalSettings::SETTING_LOCALE?
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9030
-----------------------------------------------------------
On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103434/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2011, 9:13 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> The patch resets time format in digital clock plasmoid when the user changes the \
> 24h configuration in active-settings.
> The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering \
> if I should add this change to kdelibs instead of kde-workspace to avoid \
> duplicating code. Anyway, I wanted someone to review the code to see if there can \
> be any side effect.
>
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
>
>
> Diffs
> -----
>
> plasma/generic/applets/digital-clock/clock.h 4aec3fd
> plasma/generic/applets/digital-clock/clock.cpp dd03692
>
> Diff: http://git.reviewboard.kde.org/r/103434/diff/diff
>
>
> Testing
> -------
>
> Works in Plasma Active. In Plasma Desktop kcmlocale does not call \
> KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does \
> not take effect. Other kcm modules (e.g. keyboard), call emitChange.
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103434/">http://git.reviewboard.kde.org/r/103434/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 18th, 2011, 8:33 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103434/diff/2/?file=43561#file43561line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/digital-clock/clock.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void Clock::resetTimeFormat(int category)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">100</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// Force reparsing of the new settings we care about.</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">language</span> <span class="o">=</span> \
<span class="n">KGlobal</span><span class="o">::</span><span \
class="n">locale</span><span class="p">()</span><span class="o">-></span><span \
class="n">language</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">102</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">setLanguage</span><span class="p">(</span><span \
class="n">language</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this still realy ought \
to be done in klocale </pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, we \
could add a KLocale::commit() call to make any changes in KLocale visible to \
everybody. That call would replace the \
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, \
KGlobalSettings::SETTING_COMPLETION) that I am using in plasma-mobile. \
KLocale::commit() would use KGlobalSettings::self()->emitChange() internally, we \
can add KGlobalSetings::SETTINGS_LOCALE as David suggested below. There would be a \
private slot KLocale::updateChanges() listening to emitChange that would reparse the \
config files. Of course we will need to update the documentation about emitChange and \
that would not work for KDE SC <= 4.7.4 because of the addition of \
KGlobalSetings::SETTINGS_LOCALE.
In bug #289094 particular case the will be the problem of synchronizing \
KLocale::updateChanges() with the Clock::generatePixmap(); Clock::update() calls in \
the clock plasmoid. KLocale::updateChanges() would have to emit a signal to indicate \
the changes has been updated or the changes will take place only on the next update, \
which can take almost a minute in Plasma Active. The current patch update the time \
format instantaneously.
Another problem with this approach is that we cannot prevent anybody else from \
listening to KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, \
KGlobalSettings::SETTING_LOCALE). Hmmm we could add a private enum to accomodate \
KGlobalSettings::SETTING_LOCALE?</pre> <br />
<p>- Lamarque Vieira</p>
<br />
<p>On December 16th, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch resets time format in digital clock plasmoid when the user \
changes the 24h configuration in active-settings.
The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering \
if I should add this change to kdelibs instead of kde-workspace to avoid duplicating \
code. Anyway, I wanted someone to review the code to see if there can be any side \
effect.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works in Plasma Active. In Plasma Desktop kcmlocale does not call \
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does \
not take effect. Other kcm modules (e.g. keyboard), call emitChange.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289094">289094</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/digital-clock/clock.h <span style="color: \
grey">(4aec3fd)</span></li>
<li>plasma/generic/applets/digital-clock/clock.cpp <span style="color: \
grey">(dd03692)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103434/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic